Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting access as a config #4075

Closed
FishtownBuildBot opened this issue Sep 14, 2023 · 0 comments · Fixed by #4146
Closed

Allow setting access as a config #4075

FishtownBuildBot opened this issue Sep 14, 2023 · 0 comments · Fixed by #4146
Assignees
@matthewshaver
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.7 Docs impact for the v1.7 release (Oct 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear
Milestone
dbt Core v1.7 Doc...

Comments

@FishtownBuildBot
Copy link

FishtownBuildBot commented Sep 14, 2023 •
edited by jtcohen6
Loading

Read this issue for context & motivation:

Where to change?

https://docs.getdbt.com/docs/collaborate/govern/model-access
https://docs.getdbt.com/reference/resource-properties/access - move from "General properties" to "General configs"

What's the change?

Starting in dbt-core v1.7, it will be possible to set access as a "config", instead of just as a "property":

# dbt_project.yml
models:
  my_project_name:
    subfolder_name:
      +group: <my_group>
      +access: private  # sets default for all models in this subfolder
models:
  - name: my_public_model
    access: public # previous, still supported
    config:
      access: public # newly supported
    
    # you just cannot set it in *both* places
-- models/my_public_model.sql

{{ config(access = "public") }}

select ...
@FishtownBuildBot FishtownBuildBot mentioned this issue Sep 14, 2023
Merged
4 tasks
@runleonarun runleonarun added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt Core The changes proposed in this issue relate to dbt Core labels Sep 14, 2023
@jtcohen6 jtcohen6 added dbt-core v1.7 Docs impact for the v1.7 release (Oct 2023) idea Proposes an idea for new content labels Sep 19, 2023
@jtcohen6 jtcohen6 added this to the dbt Core v1.7 Documentation milestone Sep 19, 2023
@jtcohen6 jtcohen6 changed the title Docs Changes Needed from dbt-core PR #8635 Allow setting access as a config Sep 19, 2023
@matthewshaver matthewshaver mentioned this issue Sep 27, 2023
Merged
8 tasks
@matthewshaver matthewshaver linked a pull request Sep 27, 2023 that will close this issue
Expanding access to configs #4146
Merged
8 tasks
@matthewshaver matthewshaver self-assigned this Sep 27, 2023
@jtcohen6 jtcohen6 mentioned this issue Oct 11, 2023
Closed
1 task
matthewshaver added a commit that referenced this issue Oct 11, 2023
@matthewshaver
Expanding access to configs (#4146)
890c1c0 
## What are you changing in this pull request and why?

Adding to the access page per
#4075

Also moving the page to the resource configs files

## Checklist
- [x] Add versioning components, as described in [Versioning
Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages)

- [x] Review the [Content style
guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md)
and [About
versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version)
so my content adheres to these guidelines.
- [x] Add a checklist item for anything that needs to happen before this
PR is merged, such as "needs technical review" or "change base branch."

Adding new pages (delete if not applicable):
- [x] Add page to `website/sidebars.js`
- [x] Provide a unique filename for the new page

Removing or renaming existing pages (delete if not applicable):
- [x] Remove page from `website/sidebars.js`
- [x] Add an entry `website/static/_redirects`
- [x] [Ran link
testing](https://github.com/dbt-labs/docs.getdbt.com#running-the-cypress-tests-locally)
to update the links that point to the deleted page
@runleonarun runleonarun removed the idea Proposes an idea for new content label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewshaver matthewshaver

Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core dbt-core v1.7 Docs impact for the v1.7 release (Oct 2023) improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
dbt Core v1.7 Documentation
Development

Successfully merging a pull request may close this issue.

Expanding access to configs dbt-labs/docs.getdbt.com
4 participants
@runleonarun @jtcohen6 @matthewshaver @FishtownBuildBot