Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request to Update Twitter Icon to X #4055

Closed
1 task done
lalitkumawat1m opened this issue Sep 10, 2023 · 3 comments · Fixed by #4490
Closed
1 task done

Request to Update Twitter Icon to X #4055

lalitkumawat1m opened this issue Sep 10, 2023 · 3 comments · Fixed by #4490
Assignees
@mirnawong1 @lalitkumawat1m
Labels
bug Something isn't working engineering improvement that requires site engineering help or back up

Comments

@lalitkumawat1m
Copy link

lalitkumawat1m commented Sep 10, 2023 •
edited
Loading

Contributions

  • I have read the contribution docs, and understand what's expected of me.

What page(s) or areas on docs.getdbt.com are affected?

Footer Section

Screenshot

Screenshot 2023-09-10 082344

What changes are you suggesting?

Twitter logo should be changed to X

Additional information

@mirnawong1 @KiraFuruichi
I am just starting with open source contribution. I would love to take this issue as my first ever contribution could you please assign this to me?
@lalitkumawat1m lalitkumawat1m added bug Something isn't working engineering improvement that requires site engineering help or back up labels Sep 10, 2023
@mirnawong1
Copy link
Contributor

hey @lalitkumawat1m , that sounds awesome and thanks so much for tackling this on 💪! I've assigned it to you and let me know if you have any questions on this!

@lalitkumawat1m
Copy link
Author

Hey @mirnawong1, I'm facing an issue while setting up locally

How to resolve it ?
Screenshot 2023-09-12 061903

@mirnawong1
Copy link
Contributor

hey @lalitkumawat1m sorry to hear you're having this issue! what step are you unable to complete in terms of setting up locally?

@mirnawong1 mirnawong1 mentioned this issue Nov 16, 2023
Merged
mirnawong1 added a commit that referenced this issue Nov 16, 2023
@mirnawong1
update twitter logo (#4490)
2eec806 
this pr updates the twitter logo on docs.getdbt.com site

Resolves #4055
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirnawong1 mirnawong1

@lalitkumawat1m lalitkumawat1m

Labels
bug Something isn't working engineering improvement that requires site engineering help or back up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update twitter logo dbt-labs/docs.getdbt.com
2 participants
@mirnawong1 @lalitkumawat1m