Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better organize list of adapters in sidebar (profile setup) #2853

Closed
owenprough-sift opened this issue Feb 13, 2023 · 5 comments · Fixed by #3341 or #5177
Closed

Better organize list of adapters in sidebar (profile setup) #2853

owenprough-sift opened this issue Feb 13, 2023 · 5 comments · Fixed by #3341 or #5177
Assignees
@dataders @mirnawong1
Labels
adapters

Comments

@owenprough-sift
Copy link
Contributor

docs.getdbt.com/website/sidebars.js

Line 611 in 94f1e77

items: [

Currently the adapter-specific profile setups are listed in no discernible order.

Ideas of better ways to organize them:

  • Alphabetical (keeping profiles.yml first)
  • profiles.yml first followed by dbt Labs-maintained adapters (alphabetical) followed by other adapters (alphabetical)
@owenprough-sift
Copy link
Contributor Author

Exhibit A: the present lawless wasteland

image

@owenprough-sift owenprough-sift changed the title Alphabetize list of adapters in sidebar Better organize list of adapters in sidebar (profile setup) Feb 13, 2023
@dataders dataders linked a pull request May 10, 2023 that will close this issue
Move warehouse setup pages and layout #3341
Merged
@owenprough-sift
Copy link
Contributor Author

@dataders it's not clear to me how #3341 addresses this issue. The adapters are still have no discernible order in the "deploy preview" linked from the PR, and there remains no particular order to them in sidebars.js.

@owenprough-sift
Copy link
Contributor Author

@mirnawong1 I don't think this issue was actually addressed.

As of today, the adapters are still listed in an order which is all willy-nilly:
image

@mirnawong1
Copy link
Contributor

hey @owenprough-sift , oh thanks for flagging this and i was under the impression this issue related to the adapters set up and not configs. I'll take a look to see if we can bring some structure here, thank you!

@mirnawong1 mirnawong1 reopened this Dec 6, 2023
@mirnawong1
Copy link
Contributor

going to review this this week

@mirnawong1 mirnawong1 self-assigned this Mar 27, 2024
@mirnawong1 mirnawong1 mentioned this issue Mar 27, 2024
Merged
nghi-ly added a commit that referenced this issue Mar 27, 2024
@nghi-ly
sort adapters order (#5177)
1945b27 
this pr sets to organize the list of adapters in the sidebar for dbt
core setup and adapter configs. adapters organized as follows:

- about connections and  profiles.yml 
- followed by dbt Labs-maintained adapters (alphabetical) 
- followed by other adapters (alphabetical)

Resolves #2853
Resolves #2854

thanks for the issues and patience @owenprough-sift !
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dataders dataders

@mirnawong1 mirnawong1

Labels
adapters
Projects
None yet
Milestone
No milestone
4 participants
@runleonarun @dataders @owenprough-sift @mirnawong1