Skip to content

Commit f61ef68

Browse files
authoredJun 3, 2024··
Improves readability but rearranging the list of refable nodes for expected property in exposures (#5576)
## What are you changing in this pull request and why? This PR reorders the list of refable node options for `Expected` property to improve readability: * Include the comment about the source immediately after the source node. This comes after the metric node now, which can be an additional mental jump. * Downstream to upstream: this is subtle, but it would help to first list metric, then ref, and finally source nodes to communicate likely downstream node exposures before unlikely upstream node exposures. <!--- Describe your changes and why you're making them. If related to an open issue or a pull request on dbt Core, then link to them here! To learn more about the writing conventions used in the dbt Labs docs, see the [Content style guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md). --> ## Checklist <!-- Uncomment when publishing docs for a prerelease version of dbt: - [ ] Add versioning components, as described in [Versioning Docs](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-entire-pages) - [ ] Add a note to the prerelease version [Migration Guide](https://github.com/dbt-labs/docs.getdbt.com/tree/current/website/docs/docs/dbt-versions/core-upgrade) --> - [ ] Review the [Content style guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md) so my content adheres to these guidelines. - [ ] For [docs versioning](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#about-versioning), review how to [version a whole page](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#adding-a-new-version) and [version a block of content](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/single-sourcing-content.md#versioning-blocks-of-content). - [ ] Add a checklist item for anything that needs to happen before this PR is merged, such as "needs technical review" or "change base branch."
2 parents 8d70078 + 7d258b5 commit f61ef68

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed
 

‎website/docs/docs/build/exposures.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ _Required:_
8484
<VersionBlock firstVersion="1.4">
8585

8686
_Expected:_
87-
- **depends_on**: list of refable nodes, including `ref`, `source`, and `metric` (While possible, it is highly unlikely you will ever need an `exposure` to depend on a `source` directly)
87+
- **depends_on**: list of refable nodes, including `metric`, `ref`, and `source`. While possible, it is highly unlikely you will ever need an `exposure` to depend on a `source` directly.
8888

8989
</VersionBlock>
9090

0 commit comments

Comments
 (0)
Please sign in to comment.