-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-975] [Feature] Parity on create_table_as
for python and SQL model
#414
Comments
create_table_as
for python and SQL modelcreate_table_as
for python and SQL model
Hi! |
Try to update https://github.com/xg1990/dbt-spark/blob/feature/partition-for-py-model/dbt/include/spark/macros/materializations/table.sql
|
I created my first python model with dbt and its look like the config for location_root and partition by do nothing. I found this issue, is there any updates or progress about this? |
Do you happen to have any updates on the location_root and partition_by issues? |
same here! +1 to this as it seems that at least spark session adapter would have the |
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days. |
Any movement on this? |
Describe the feature
spark__create_table_as macro support options including
partition_by
,clustered_by
,file_format
,location_root
, and more options defined in options_clause.Right now in python models we are just saving everything as delta format with the default setting. We should reach parity for this for python models where possible and raise a clear error when running with options that is not supported.
Motivation:
User would be able to optimize the storage format based on their usage of the table.
Acceptance criteria
Python model would materialize the table with the correct option, and raise error when unsupported option is being specified.
Tests for the PR
You should add integration tests to run the table materialization with supported options, then check that the table has intended property, for example
SHOW PARTITION table
(link) can be used to check partitions. You should also add tests to to make sure we raised the error on unsupported options.The text was updated successfully, but these errors were encountered: