From 7cb04498125467b674699d2a3e0f1f7ea2f8e3fd Mon Sep 17 00:00:00 2001
From: Mila Page <versusfacit@users.noreply.github.com>
Date: Thu, 21 Mar 2024 01:16:08 -0700
Subject: [PATCH] Shape up workflow and add changelog.

---
 .../Under the Hood-20240321-011551.yaml       |  6 ++
 .github/workflows/release-internal.yml        | 56 ++++++++-----------
 2 files changed, 28 insertions(+), 34 deletions(-)
 create mode 100644 .changes/unreleased/Under the Hood-20240321-011551.yaml

diff --git a/.changes/unreleased/Under the Hood-20240321-011551.yaml b/.changes/unreleased/Under the Hood-20240321-011551.yaml
new file mode 100644
index 000000000..1ef1dabe9
--- /dev/null
+++ b/.changes/unreleased/Under the Hood-20240321-011551.yaml	
@@ -0,0 +1,6 @@
+kind: Under the Hood
+body: Finalize the spark internal release build workflow
+time: 2024-03-21T01:15:51.60905-07:00
+custom:
+  Author: versusfacit
+  Issue: "38"
diff --git a/.github/workflows/release-internal.yml b/.github/workflows/release-internal.yml
index 462e14819..2296ea710 100644
--- a/.github/workflows/release-internal.yml
+++ b/.github/workflows/release-internal.yml
@@ -1,3 +1,15 @@
+# What?
+#
+# Tag and release an arbitrary sha. Uploads to an internal archive for further processing.
+#
+# How?
+#
+# After checking out and testing the provided sha, the image is built and uploaded.
+#
+# When?
+#
+# Manual trigger.
+
 name: Release internal patch
 
 on:
@@ -8,57 +20,33 @@ on:
         type: string
         required: true
       sha:
-        description: "The sha to use (leave empty to use latest on main)"
-        type: string
-        required: false
-      package_test_command:
-        description: "Package test command"
-        type: string
-        default: "python -c \"import dbt.adapters.spark\""
-        required: true
-      dbms_name:
-        description: "The name of the warehouse the adapter connects to."
-        type: string
-        default: "spark"
-        required: true
-  workflow_call:
-    inputs:
-      version_number:
-        description: "The release version number (i.e. 1.0.0b1)"
+        description: "The ref (sha or branch name) to use"
         type: string
+        default: "main"
         required: true
-      sha:
-        description: "The sha to use (leave empty to use latest on main)"
-        type: string
-        required: false
       package_test_command:
         description: "Package test command"
         type: string
         default: "python -c \"import dbt.adapters.spark\""
         required: true
-      dbms_name:
-        description: "The name of the warehouse the adapter connects to."
-        type: string
-        default: "spark"
-        required: true
 
 defaults:
   run:
-    shell: bash
+    shell: "bash"
 
 env:
   PYTHON_TARGET_VERSION: 3.11
 
 jobs:
   invoke-reusable-workflow:
-    name: Build and Release Internally
+    name: "Build and Release Internally"
 
-    uses: VersusFacit/dbt-release/.github/workflows/internal-archive-release.yml@main
+    uses: "dbt-labs/dbt-release/.github/workflows/internal-archive-release.yml@mp/finish_internal_workflow"
 
     with:
-      version_number: ${{ inputs.version_number }}
-      package_test_command: ${{ inputs.package_test_command }}
-      dbms_name: ${{ inputs.dbms_name }}
-      sha: ${{ inputs.sha }}
+      version_number: "${{ inputs.version_number }}"
+      package_test_command: "${{ inputs.package_test_command }}"
+      dbms_name: "spark"
+      sha: "${{ inputs.sha }}"
 
-    secrets: inherit
+    secrets: "inherit"