Consolidated meta config to use the same models #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DevonFulcher
requested review from
QMalcolm,
graciegoheen and
a team
as code owners
|
Can we do the version bump in this PR? I think it would be safer to merge those together to make sure we don't accidentally release a breaking version without bumping the minor version (in case someone did a patch version bump and released it before we had a chance to release the new minor version). |
…nsolidate_meta_config
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses this feedback to consolidate the meta config into central models. This is technically a breaking change because some classes have been deleted, but Courtney confirmed that these classes are not being used by dbt-core.
Checklist
changie newto create a changelog entry