Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spec Update] Redesign create_metric: default True and dict value to support create_metric_display_name #55

Open
3 tasks done
Tracked by #7
callum-mcdata opened this issue May 17, 2023 · 0 comments
Labels

Comments

@callum-mcdata
Copy link
Contributor

callum-mcdata commented May 17, 2023

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward change to existing dbt-semantic-interfaces functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Do measures always create metrics? In a world where all complicated metrics are defined as derived metrics on top of simple metrics, this might be true.

This Issue is complicated by the fact that create_metric = true has implications in parsing for core.

Additionally we have the create_metric_display_name property. If we want to retain this then we should make create_metric a dict to support it as a class. That way someone isn't adding the display value without create metric

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@callum-mcdata callum-mcdata added the enhancement New feature or request label May 17, 2023
@callum-mcdata callum-mcdata changed the title [Feature] Alter create_metric to be default True [Feature] Redesign create_metric: default True and dict value to support create_metric_display_name May 18, 2023
@marcodamore marcodamore changed the title [Feature] Redesign create_metric: default True and dict value to support create_metric_display_name [Spec Update] Redesign create_metric: default True and dict value to support create_metric_display_name May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants