-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Update spec to include custom_granularities
#338
Comments
I have two questions:
@dbeatty10 Wondering if you have more context on this? |
Also for context, we've already gotten full approval on everything (and it's all released to versionless) except the |
@graciegoheen brining the conversation here from slack:
|
Got it - so then really these are In that case, should the config be called
Or maybe it's just removing the redundant "column" like:
|
Correct! I like the first option. Removing
|
Is this your first time submitting a feature request?
Describe the feature
Its currently possible to add a time_spine configuration to a
model
configuration in order to make this model available to Metricflow to use in time based joins.We want to extend this spec to allow users to define custom granularities that a present in the time spine model, like fiscal quarter or 4-5-4 retail months. These custom granularities will then be accesible for Metrciflows built in time operations, like offsets, windows and dynamic granularity calculations.
The proposed spec for adding a custom granularity is below:
The text was updated successfully, but these errors were encountered: