Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time granularity handling configuration #145

Open
3 tasks done
tlento opened this issue Sep 8, 2023 · 1 comment
Open
3 tasks done

Add time granularity handling configuration #145

tlento opened this issue Sep 8, 2023 · 1 comment
Assignees
Labels
backlog Backport 0.2.latest Fix should be backported to 0.2.latest enhancement New feature or request

Comments

@tlento
Copy link
Collaborator

tlento commented Sep 8, 2023

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward change to existing dbt-semantic-interfaces functionality, rather than a Big Idea better suited to a discussion

Describe the feature

See dbt-labs/metricflow#714 for background context.

Sometimes users have a granularity set for a time dimension that is coarser than the granularity stored in their warehouse. While this does not follow our recommended practice, there are valid use cases for doing so. As such, we need to be able to coerce the data into the expected granularity when needed.

However, we do not want to just date_trunc() everything all the time, as that leads to confusing SQL and wasted processing.

The solution we've settled on is to provide a configuration parameter users can set to conform the values to the specified granularity.

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@tlento tlento added the enhancement New feature or request label Sep 8, 2023
@tlento tlento self-assigned this Sep 8, 2023
@tlento tlento added the Backport 0.2.latest Fix should be backported to 0.2.latest label Sep 8, 2023
@tlento tlento added Backport 0.2.latest Fix should be backported to 0.2.latest and removed Backport 0.2.latest Fix should be backported to 0.2.latest labels Oct 10, 2023
@tlento
Copy link
Collaborator Author

tlento commented Oct 10, 2023

Update - this is now a backlog enhancement that may never get built, as we've decided to always coerce to granularity. We will see if a need for this emerges in the near future, so let's hold this open for now.

@tlento tlento added the backlog label Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Backport 0.2.latest Fix should be backported to 0.2.latest enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant