Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBT 'hours_to_expiration' on table [BigQuery] #225

Closed
elvis-scpl opened this issue Jul 24, 2023 · 6 comments · May be fixed by #230
Closed

DBT 'hours_to_expiration' on table [BigQuery] #225

elvis-scpl opened this issue Jul 24, 2023 · 6 comments · May be fixed by #230
Labels
bug Something isn't working Stale triage
Milestone
0.9.0

Comments

@elvis-scpl
Copy link

Describe the bug

I want to be able to use dbt "hours_to_expiration" to define BigQuery "Table expiration", but the configuration isn't being received.

Steps to reproduce

Just use a simple configuration for the Google Sheets and try to add the "hours_to_expiration" and validate that the option isn't added to BigQuery

version: 2

sources:
  - name: test
    loader: gcloud storage
    dataset: "{{ target.dataset }}"
    tables:
      - name: test
        description: Sheet
        hours_to_expiration: 24
        external:
          location: 'https://docs.google.com/spreadsheets/d/id'
          options:
            format: google_sheets
            skip_leading_rows: 1
            sheet_range: 'sheetrange'
        columns:
          - name: column_name
            data_type: STRING
            description: "Column Name"

Expected results

The table should be created with the Table expiration configured.

Actual results

Table expiration doesn't change from NEVER

System information

  • BigQuery

The output of dbt --version:

Core:
  - installed: 1.5.2
Plugins:
  - bigquery: 1.5.3 - Up to date!

The operating system you're using:
Windows
The output of python --version:
Python 3.11.2
@elvis-scpl elvis-scpl added bug Something isn't working triage labels Jul 24, 2023
@thomas-vl thomas-vl mentioned this issue Aug 21, 2023
Open
3 tasks
@thomas-vl
Copy link
Contributor

thomas-vl commented Aug 21, 2023 •
edited
Loading

I've created a PR to be able to add table expiry on an external table.

@elvis-scpl
Copy link
Author

Thanks, @thomas-vl!

@github-actions GitHub Actions
Copy link

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Feb 18, 2024
@github-actions GitHub Actions
Copy link

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Feb 25, 2024
@dataders dataders reopened this Apr 4, 2024
@dataders dataders added this to the 1.0.0 milestone Apr 4, 2024
@github-actions github-actions bot removed the Stale label Apr 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days.

@github-actions github-actions bot added the Stale label Oct 2, 2024
@github-actions GitHub Actions
Copy link

Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Stale triage
Projects
None yet
Milestone
0.9.0
Development

Successfully merging a pull request may close this issue.

Add table expiry thomas-vl/dbt-external-tables
3 participants
@dataders @thomas-vl @elvis-scpl