Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functional tests for custom incremental strategies names 'microbatch' #10716

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Add functional tests for custom incremental strategies names 'microbatch' #10716

merged 2 commits into from
Sep 16, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Sep 16, 2024 •
edited by QMalcolm
Loading

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@MichelleArk MichelleArk requested a review from a team as a code owner September 16, 2024 06:30
@cla-bot cla-bot bot added the cla:yes label Sep 16, 2024
@MichelleArk MichelleArk changed the title Add functional tests for custom incremental strategies names 'microba… Add functional tests for custom incremental strategies names 'microbatch' Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk MichelleArk added the Skip Changelog Skips GHA to check for changelog file label Sep 16, 2024
@codecov Codecov
Copy link

codecov bot commented Sep 16, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (6c111f2) to head (0b9e901).
Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #10716      +/-   ##
==========================================
- Coverage   88.92%   88.89%   -0.04%     
==========================================
  Files         180      180              
  Lines       22847    22847              
==========================================
- Hits        20317    20310       -7     
- Misses       2530     2537       +7
Flag Coverage Δ
integration 86.09% <ø> (-0.04%) ⬇️
unit 62.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.44% <ø> (ø)
Integration Tests 86.09% <ø> (-0.04%) ⬇️

@QMalcolm
Point dev-requirement of dbt-adapters back to the main branch
0b9e901 
The associated branch/PR in `dbt-adapters` that we were previously
pointing to has been merged. Thus we can point back to `main` again.
QMalcolm
QMalcolm approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@QMalcolm QMalcolm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢 🇮🇹

@QMalcolm QMalcolm merged commit 77aeb3e into main Sep 16, 2024
59 checks passed
@QMalcolm QMalcolm deleted the test-microbatch-backcompat branch September 16, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QMalcolm QMalcolm QMalcolm approved these changes

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichelleArk @QMalcolm