-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CT-458] Catalog queries should filter on specific relations in busy schemas #4997
Comments
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days. |
This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please comment on the issue or else it will be closed in 7 days. |
Although we are closing this issue as stale, it's not gone forever. Issues can be reopened if there is renewed community interest. Just add a comment to notify the maintainers. |
Reopening on behalf of enterprise customer. |
Closing this out, since we completed the dbt-core implementation! Adapter implementations are ongoing :) |
Reopening on behalf of enterprise customer. |
Related:
To enable this,
_get_catalog_schemas
would need to return a specific set of tables, rather than a set of database-schema combos (SchemaSearchMap
):dbt-core/core/dbt/adapters/base/impl.py
Lines 313 to 338 in 7f953a6
Given that we'll need to interpolate table names into actual queries, maybe we could have a rule like: If a database-schema has >100 objects in it, just catalog the entire schema; any less, pass the specific object names as filters.
We see this issue crop up on several adapters, including most recently Redshift. Catalog generation is different from cache generation in two ways:
The text was updated successfully, but these errors were encountered: