Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make pk optional #10973

Closed
wants to merge 1 commit into from
Closed

make pk optional #10973

wants to merge 1 commit into from

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Nov 4, 2024

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Nov 4, 2024
Copy link
Contributor

github-actions bot commented Nov 4, 2024

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.37%. Comparing base (bdf28d7) to head (50815a4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10973      +/-   ##
==========================================
- Coverage   89.14%   86.37%   -2.78%     
==========================================
  Files         183      183              
  Lines       23553    23553              
==========================================
- Hits        20996    20343     -653     
- Misses       2557     3210     +653     
Flag Coverage Δ
integration 86.37% <100.00%> (-0.15%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 86.37% <100.00%> (-2.78%) ⬇️
Integration Tests 86.37% <100.00%> (-0.15%) ⬇️

@emmyoop emmyoop closed this Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant