Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Bump the lower bound of dbt-adapters within 1.8.latest #10768

Open
2 tasks done
dbeatty10 opened this issue Sep 24, 2024 · 0 comments
Open
2 tasks done

[Bug] Bump the lower bound of dbt-adapters within 1.8.latest #10768

dbeatty10 opened this issue Sep 24, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Sep 24, 2024

Is this a new bug in dbt-core?

  • I believe this is a new bug in dbt-core
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

These PRs across dbt-core and dbt-adapters are tightly coupled and need to be installed together:

The first was released in dbt-core==1.8.6, the second in dbt-adapters==1.4.1. The third has yet to be released.

The net effect is that:

  • dbt-core<=1.8.5 and dbt-adapters<=1.4.0 are compatible
  • dbt-core>=1.8.6 and dbt-adapters>=1.4.1 are compatible*
  • dbt-core<=1.8.5 and dbt-adapters>=1.4.1 are not compatible
  • dbt-core>=1.8.6 and dbt-adapters<=1.4.0 are not compatible

* but has its own bugs (#10754, #10763) because #10755 was not included in dbt-core==1.8.6.

Expected Behavior

On main, we ensure dbt-adapters 1.7+.

On 1.8.latest, we lower bound to dbt-adapters 1.1.1.

We should use either requirements (or constraints) to ensure that either all 3 are installed together or none are.

Steps To Reproduce

With the 1.8.latest branch of dbt-core, install dbt-adapters==1.4.0, then run the functional tests. Although I didn't try this out, I expect there to be failing tests. If not, then we should add the tests that would cause it to fail!

Alternative Steps to Reproduce

Or within a virtual environment, do either of these:

python -m pip install dbt-core==1.8.5 and dbt-adapters==1.4.1
python -m pip install dbt-core==1.8.6 and dbt-adapters==1.4.0

Then replicate the situation described here:

More Alternative Steps to Reproduce

Or alternatively, do these install commands:

python -m pip install dbt-core==1.8.6 and dbt-adapters==1.4.1

And follow any of these reproducible examples:

Relevant log output

No response

Environment

- OS:
- Python:
- dbt:

Which database adapter are you using with dbt?

No response

Additional Context

We had a series of regressions due to the feature in dbt-labs/dbt-adapters#236 being released. While dbt-core and dbt-adapters were decoupled beginning in dbt-core v1.8, dbt-labs/dbt-adapters#236 actually depended upon corresponding PRs in dbt-core to work properly (namely, #10290 and #10755).

So dbt-labs/dbt-adapters#236 shouldn't have been merged + released until the corresponding dbt-core PRs were also ready to be merged + released (and lower bound of dbt-adapters bumped up). Since these PRs were related to a feature request, this shouldn't have happened until a minor release of dbt-core.

@dbeatty10 dbeatty10 added bug Something isn't working triage and removed triage labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant