[Bug] Bump the lower bound of dbt-adapters
within 1.8.latest
#10768
Labels
bug
Something isn't working
dbt-adapters
within 1.8.latest
#10768
Is this a new bug in dbt-core?
Current Behavior
These PRs across dbt-core and dbt-adapters are tightly coupled and need to be installed together:
The first was released in dbt-core==1.8.6, the second in dbt-adapters==1.4.1. The third has yet to be released.
The net effect is that:
dbt-core<=1.8.5 and dbt-adapters<=1.4.0
are compatibledbt-core>=1.8.6 and dbt-adapters>=1.4.1
are compatible*dbt-core<=1.8.5 and dbt-adapters>=1.4.1
are not compatibledbt-core>=1.8.6 and dbt-adapters<=1.4.0
are not compatible* but has its own bugs (#10754, #10763) because #10755 was not included in
dbt-core==1.8.6
.Expected Behavior
On
main
, we ensure dbt-adapters 1.7+.On
1.8.latest
, we lower bound to dbt-adapters 1.1.1.We should use either requirements (or constraints) to ensure that either all 3 are installed together or none are.
Steps To Reproduce
With the
1.8.latest
branch of dbt-core, installdbt-adapters==1.4.0
, then run the functional tests. Although I didn't try this out, I expect there to be failing tests. If not, then we should add the tests that would cause it to fail!Alternative Steps to Reproduce
Or within a virtual environment, do either of these:
Then replicate the situation described here:
More Alternative Steps to Reproduce
Or alternatively, do these install commands:
And follow any of these reproducible examples:
this
referrence on incremental model with alias #10754 (comment)incremental
mode for versioned incremental models #10763 (comment)Relevant log output
No response
Environment
Which database adapter are you using with dbt?
No response
Additional Context
We had a series of regressions due to the feature in dbt-labs/dbt-adapters#236 being released. While dbt-core and dbt-adapters were decoupled beginning in dbt-core v1.8, dbt-labs/dbt-adapters#236 actually depended upon corresponding PRs in dbt-core to work properly (namely, #10290 and #10755).
So dbt-labs/dbt-adapters#236 shouldn't have been merged + released until the corresponding dbt-core PRs were also ready to be merged + released (and lower bound of dbt-adapters bumped up). Since these PRs were related to a feature request, this shouldn't have happened until a minor release of dbt-core.
The text was updated successfully, but these errors were encountered: