Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech debt] Add automation to auto-generate core_types_pb2.py on branches #10660

Open
1 task done
MichelleArk opened this issue Sep 3, 2024 · 0 comments
Open
1 task done
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality user docs [docs.getdbt.com] Needs better documentation

Comments

@MichelleArk
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-core

Short description

Currently we use make core_proto_types locally to generate the core_types_pb2.py file locally and push that up as part of a PR that introduces proto changes. This means developer versions of protoc can differ locally and result in inconsistent versions used to generate the file.

Instead, let's create some GH automation that generates the file and commits it to a branch if it detected changes.

This can use protoc 5.26.1 for now (will need to be installed from source) until #10658 is closed.

Acceptance criteria

GH automation that generates the file and commits it to a branch if it detected changes.

This can use protoc 5.26.1 for now (will need to be installed from source).

Suggested Tests

n/a - GH automation

Impact to Other Teams

n/a

Will backports be required?

nope

Context

No response

@MichelleArk MichelleArk added user docs [docs.getdbt.com] Needs better documentation tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality labels Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

No branches or pull requests

1 participant