You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we use make core_proto_types locally to generate the core_types_pb2.py file locally and push that up as part of a PR that introduces proto changes. This means developer versions of protoc can differ locally and result in inconsistent versions used to generate the file.
Instead, let's create some GH automation that generates the file and commits it to a branch if it detected changes.
This can use protoc 5.26.1 for now (will need to be installed from source) until #10658 is closed.
Acceptance criteria
GH automation that generates the file and commits it to a branch if it detected changes.
This can use protoc 5.26.1 for now (will need to be installed from source).
Suggested Tests
n/a - GH automation
Impact to Other Teams
n/a
Will backports be required?
nope
Context
No response
The text was updated successfully, but these errors were encountered:
MichelleArk
added
user docs
[docs.getdbt.com] Needs better documentation
tech_debt
Behind-the-scenes changes, with little direct impact on end-user functionality
labels
Sep 3, 2024
Housekeeping
Short description
Currently we use
make core_proto_types
locally to generate thecore_types_pb2.py
file locally and push that up as part of a PR that introduces proto changes. This means developer versions ofprotoc
can differ locally and result in inconsistent versions used to generate the file.Instead, let's create some GH automation that generates the file and commits it to a branch if it detected changes.
This can use protoc 5.26.1 for now (will need to be installed from source) until #10658 is closed.
Acceptance criteria
GH automation that generates the file and commits it to a branch if it detected changes.
This can use protoc 5.26.1 for now (will need to be installed from source).
Suggested Tests
n/a - GH automation
Impact to Other Teams
n/a
Will backports be required?
nope
Context
No response
The text was updated successfully, but these errors were encountered: