Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] --event-start-time and --event-end-time as CLI flags for specifying microbatch start and end times #10635

Closed
1 task done
Tracked by #10624
QMalcolm opened this issue Aug 29, 2024 · 1 comment · Fixed by #10594
Closed
1 task done
Tracked by #10624
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Aug 29, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

In #10624 we're building a new type of incremental model strategy, microbatch. The microbatch strategy is cool for a lot of reasons, that can be read about elsewhere. To support that we need a concept an event_start_time and event_end_time. Specifically, people should be able to specify these values via the CLI
A CLI invocation using the flags would look like

$ dbt run --event-time-start "2024-09-01 00:00:00" --event-time-end "2024-09-04 00:00:00"

Acceptance criteria

  • --event-time-start can be passed as a CLI argument
  • --event-time-end can be passed as a CLI argument

Suggested Tests

  1. --event-time-start can be specified in the CLI without error
  2. --event-time-end can be specified in the CLI without error

Impact to Other Teams

N/A

Will backports be required?

No

Context

No response

@QMalcolm QMalcolm added the enhancement New feature or request label Sep 4, 2024
@QMalcolm QMalcolm changed the title Add --event-start-time and --event-end-time as CLI flags for specifying microbatch start and end times [FEATURE] --event-start-time and --event-end-time as CLI flags for specifying microbatch start and end times Sep 4, 2024
@QMalcolm QMalcolm changed the title [FEATURE] --event-start-time and --event-end-time as CLI flags for specifying microbatch start and end times [Feature] --event-start-time and --event-end-time as CLI flags for specifying microbatch start and end times Sep 4, 2024
@QMalcolm QMalcolm added this to the v1.9 milestone Sep 4, 2024
@QMalcolm
Copy link
Contributor Author

Resolved by #10594

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants