diff --git a/.changes/unreleased/Under the Hood-20240827-113123.yaml b/.changes/unreleased/Under the Hood-20240827-113123.yaml new file mode 100644 index 00000000000..889c07239de --- /dev/null +++ b/.changes/unreleased/Under the Hood-20240827-113123.yaml @@ -0,0 +1,6 @@ +kind: Under the Hood +body: Fix typing issues in core/dbt/contracts/sql.py +time: 2024-08-27T11:31:23.749912-05:00 +custom: + Author: QMalcolm + Issue: "10614" diff --git a/core/dbt/contracts/sql.py b/core/dbt/contracts/sql.py index 931290039bf..d7b9bcbd970 100644 --- a/core/dbt/contracts/sql.py +++ b/core/dbt/contracts/sql.py @@ -29,7 +29,8 @@ class RemoteCompileResult(RemoteCompileResultMixin): generated_at: datetime = field(default_factory=datetime.utcnow) @property - def error(self): + def error(self) -> None: + # TODO: Can we delete this? It's never set anywhere else and never accessed return None @@ -40,7 +41,7 @@ class RemoteExecutionResult(ExecutionResult): args: Dict[str, Any] = field(default_factory=dict) generated_at: datetime = field(default_factory=datetime.utcnow) - def write(self, path: str): + def write(self, path: str) -> None: writable = RunResultsArtifact.from_execution_results( generated_at=self.generated_at, results=self.results,