Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for preserving case in generate_source #161

Closed
azdoherty opened this issue Feb 27, 2024 · 1 comment
Closed

Support for preserving case in generate_source #161

azdoherty opened this issue Feb 27, 2024 · 1 comment
Labels
enhancement New feature or request triage

Comments

@azdoherty
Copy link

Describe the feature

generate_source lowercases all returned column and dataset names, it would be nice if we had an option to preserve case. When you are using bigquery case matters, MyDataset is different from mydataset.

Describe alternatives you've considered

This is already an interface implemented partially in generate_base_model in the form of case_sensitive_cols so extending a similar functionality here seems to make the most sense. I considered writing a custom script to modify the results to replace names with the known correct cases but ended up doing it manually since it was only for a handful of databases

Additional context

It applies to at least bigquery, not sure about others

Who will this benefit?

It will mean this tool works out of the box for creating sources from existing tables, instead of needing to run it then modify the results

Are you interested in contributing this feature?

yes, and I would definitely need a hand at least getting told where to start

@azdoherty azdoherty added enhancement New feature or request triage labels Feb 27, 2024
@gwenwindflower
Copy link
Contributor

Duplicate of #140 so closing for now, getting ready to merge in a PR to fix this! Thanks for flagging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage
Projects
None yet
Development

No branches or pull requests

2 participants