Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log level to INFO for the BigQuery job link #1328

Open
3 tasks done
pankajkoti opened this issue Aug 29, 2024 · 3 comments
Open
3 tasks done

Change log level to INFO for the BigQuery job link #1328

pankajkoti opened this issue Aug 29, 2024 · 3 comments
Labels
enhancement New feature or request help_wanted Extra attention is needed

Comments

@pankajkoti
Copy link

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-bigquery functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Currently I see that the job link log output is set to debug level. It would really help users have this job link printed always to have quick lookups of the job in BigQuery. I believe it's currently set to debug looking at here

Describe alternatives you've considered

No response

Who will this benefit?

Most users who would like to have the link visible in the logs for the submitted BQ job

Are you interested in contributing this feature?

Yes, I have not yet contributed, but maybe sometime soon if no else picks up until then.

Anything else?

Also want to validate if there are any reservations on changing the log level to info from the current debug level

@pankajkoti pankajkoti added enhancement New feature or request triage labels Aug 29, 2024
@pankajkoti pankajkoti changed the title [Feature] Change log level to info for the big query job link Change log level to INFO for the BigQuery job link Aug 29, 2024
@amychen1776 amychen1776 added help_wanted Extra attention is needed and removed triage labels Aug 29, 2024
@amychen1776
Copy link

amychen1776 commented Aug 29, 2024

Hi @pankajkoti at this time, we do not have capacity to tackle this on our roadmap but would always welcome a pull request :) I should also flag if you look into it, does it change the level of permissioning needed to execute of which we would want to be cautious.

@pankajkoti
Copy link
Author

does it change the level of permissioning needed to execute of which we would want to be cautious.

hi @amychen1776 thanks for the quick response. Could you throw some more light on how it depends on permissions if we would have to change just the log level?

@amychen1776
Copy link

@pankajkoti I was thinking in terms of if you need any additional permissioning in order to access the metadata tables in order to get the job link as well as for folks who want to click on the job link. It seems like there are some conversations on StackOverflow about that (when I did my high level research into what job links are)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help_wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants