Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech Debt] Job timeout functional test fails during setup, before the test catches the failure #1323

Open
2 tasks done
mikealfare opened this issue Aug 26, 2024 · 1 comment

Comments

@mikealfare
Copy link
Contributor

Is this a new bug in dbt-bigquery?

  • I believe this is a new bug in dbt-bigquery
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

The test was designed to fail during setup (expected) and then catch said failure, to demonstrate that the job timeout configuration is working as intended. However, because the test fails during setup, the test itself cannot catch the exception to evaluate it, and instead just fails outright. The test fails inconsistently, suggesting that the test setup occasionally completes in under 1s (the timeout threshold for the test).

Expected Behavior

The test should create a timeout scenario that is predictable and fails during the test execution, not during the setup. The test should then catch that exception with a pytest.raises call.

Steps To Reproduce

See failed runs for examples:
https://github.com/dbt-labs/dbt-bigquery/actions/runs/10550048706/job/29225776817

Relevant log output

No response

Environment

- OS: all/random
- Python: all/random
- dbt-core: all/random
- dbt-bigquery: all/random

Additional Context

No response

@mikealfare mikealfare added bug Something isn't working triage tech_debt and removed bug Something isn't working triage labels Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@mikealfare @colin-rogers-dbt and others