You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Models should be created and the described privileges granted but the following error occurs:
Database Error in model grants_materialized_view (models/grants_materialized_view.sql)
Invalid object type for GRANT statement: materialized_view at [6:5]
compiled Code at <REDACTED>/grants_materialized_view.sql
Relevant log output
Database Error in model grants_materialized_view (models/grants_materialized_view.sql)
Invalid object typefor GRANT statement: materialized_view at [6:5]
compiled Code at <REDACTED>/grants_materialized_view.sql
We should align on how to handle this in general. There are two approaches that are being considered:
create a render() method for relation_type that produces the correct string
most of the time this is the same (table/view), sometimes it's not (materialized_view > materialized view)
sometimes this is macro/platform specific (e.g. postgres views: drop table my_view)
create a macro per relation type, similar to how materialized views were implemented
this is very explicit with little logic in the template
there is a lot of copy past involved, though hopefully it does not change very often
for many statement types and platforms, this aligns 1:1 with platform docs, making the template act as an implementation of the platform docs (read "protocol")
We have not decided on an approach, and there's the chance someone thinks of a third approach. This is here merely for documentation of a scoping discussion.
Is this a new bug in dbt-bigquery?
Current Behavior
When using the
grants
configuration on a materialized view, the generated grant/revoke statement results in:and respectively:
This results in an error because BigQuery expect the relation type to be
materialized view
instead ofmaterialized_view
.See documentation
Expected Behavior
The grant/revoke statements execute successfully.
Steps To Reproduce
base_table.sql
:grants_materialized_view.sql
:Create the models using
dbt run
Models should be created and the described privileges granted but the following error occurs:
Relevant log output
Environment
Additional Context
Proposed fix: #1267
The text was updated successfully, but these errors were encountered: