Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADAP-1028] [Bug] primary and foreign keys are supported but not enforced #1018

Closed
2 tasks done
dbeatty10 opened this issue Nov 11, 2023 · 0 comments · Fixed by #1019
Closed
2 tasks done

[ADAP-1028] [Bug] primary and foreign keys are supported but not enforced #1018

dbeatty10 opened this issue Nov 11, 2023 · 0 comments · Fixed by #1019
Assignees
@colin-rogers-dbt
Labels
type:bug Something isn't working

Comments

@dbeatty10
Copy link
Contributor

dbeatty10 commented Nov 11, 2023 •
edited
Loading

Is this a new bug in dbt-bigquery?

  • I believe this is a new bug in dbt-bigquery
  • I have searched the existing issues, and I could not find an existing issue for this bug

Current Behavior

The source code says here that primary_key and foreign_key are enforced.

But as noted in dbt-labs/docs.getdbt.com#4419, they are supported, but not enforced.

Expected Behavior

The source code should indicated that primary_key and foreign_key are NOT_ENFORCED.

Steps To Reproduce

The actual behavior might actually be fine, but the code is not labeled accurately.

Relevant log output

No response

Environment

- OS:
- Python:
- dbt-core:
- dbt-bigquery:

Additional Context

No response
@dbeatty10 dbeatty10 added type:bug Something isn't working triage:product and removed triage:product labels Nov 11, 2023
@dbeatty10 dbeatty10 mentioned this issue Nov 11, 2023
Merged
5 tasks
@github-actions github-actions bot changed the title [Bug] primary and foreign keys are supported but not enforced [ADAP-1028] [Bug] primary and foreign keys are supported but not enforced Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colin-rogers-dbt colin-rogers-dbt

Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Primary and foreign key constraints are not enforced in BigQuery dbt-labs/dbt-bigquery
2 participants
@dbeatty10 @colin-rogers-dbt