Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tech debt] We need to ensure that dbt-athena and dbt-athena-community always match in version #743

Open
1 task done
mikealfare opened this issue Oct 17, 2024 · 0 comments

Comments

@mikealfare
Copy link
Contributor

Is this your first time submitting an issue in dbt-athena?

  • I have searched the existing issues, and I could not find an existing issue for this feature

Describe your request/question

We want dbt-athena-community to be the same package as dbt-athena for every version, down to the patch/pre-release/etc. There is no easy way to enforce this since we can't point one package to another package's version file (seemingly a hatch or setuptools limitation). And we certainly can't have calculated versions in the build dependencies in dbt-athena-community. The next best thing is to add a pre-commit check that ensures the versions are all set to the same thing. This includes:

  • dbt-athena/dbt/athena/__version__.py::version
  • dbt-athena-community/pyproject.toml::project.version
  • dbt-athena-community/pyproject.toml::project.dependencies.dbt-athena

We are comfortable bumping the version manually for now as this overlap is a temporary solution for providing backwards compatibility as dbt-athena-community users migrate to dbt-athena.

Anything else?

No response

@mikealfare mikealfare mentioned this issue Oct 17, 2024
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant