Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Include database in the Iceberg file path #686

Open
3 tasks done
ms32035 opened this issue Dec 27, 2024 · 0 comments
Open
3 tasks done

[Feature] Include database in the Iceberg file path #686

ms32035 opened this issue Dec 27, 2024 · 0 comments
Labels
feature:iceberg Issues related to Iceberg support pkg:dbt-snowflake Issue affects dbt-snowflake type:enhancement New feature request

Comments

@ms32035
Copy link

ms32035 commented Dec 27, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt-snowflake functionality, rather than a Big Idea better suited to a discussion

Describe the feature

Currently base location of an Iceberg table only supports schema and table name f"_dbt/{self.schema}/{self.name}", but to be fully unique or to prevent mixing of tables from different databases within the same path we should also add the database name.

https://github.com/dbt-labs/dbt-snowflake/blob/v1.9.0/dbt/adapters/snowflake/relation.py#L207

Describe alternatives you've considered

No response

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@ms32035 ms32035 added type:enhancement New feature request triage:product In Product's queue labels Dec 27, 2024
@amychen1776 amychen1776 added feature:iceberg Issues related to Iceberg support and removed triage:product In Product's queue labels Jan 6, 2025
@mikealfare mikealfare added the pkg:dbt-snowflake Issue affects dbt-snowflake label Jan 15, 2025
@mikealfare mikealfare transferred this issue from dbt-labs/dbt-snowflake Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:iceberg Issues related to Iceberg support pkg:dbt-snowflake Issue affects dbt-snowflake type:enhancement New feature request
Projects
None yet
Development

No branches or pull requests

3 participants