Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADAP-1125: Migrate dbt-athena into dbt-adapters #399

Merged
merged 511 commits into from
Jan 12, 2025

Conversation

mikealfare
Copy link
Contributor

@mikealfare mikealfare commented Jan 8, 2025

Migrate dbt-athena into this repo using the following shell script and call:

repo=$1
source_branch=$2
target_branch=$3

# create a remote for the legacy adapter repo and fetch the latest commits
git remote remove old || true
git remote add old https://github.com/dbt-labs/$repo.git
git fetch old

# merge the updated branch from the legacy repo into the dbt-adapters repo
git checkout $target_branch
git merge old/$source_branch --allow-unrelated-histories

# remove the remote that was created by this process
git remote remove old || true
source ./scripts/migrate-adapter.sh dbt-athena main monorepo/migrate-dbt-athena

Update workflows to include dbt-athena and dbt-athena-community.

Make updates related with code quality checks due to slightly different config.

Merge this PR as a regular merge instead of a squash merge in order to retain git blame history.

nicor88 and others added 30 commits August 21, 2023 15:10
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jérémy Guiselin <[email protected]>
Co-authored-by: Serhii Dimchenko <[email protected]>
Co-authored-by: nicor88 <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…388)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: nicor88 <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…407)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Co-authored-by: Julien Kervizic <[email protected]>
Co-authored-by: Serhii Dimchenko <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: nicor88 <[email protected]>
Copy link

cla-bot bot commented Jan 10, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @maiarareinaldo, @sashakcc, @keshihoriuchi, @voroninman, @lukas-gust, @nicor88, @skirino, @brunofaustino, @svdimchenko, @artem-garmash, @hiro-o918

@mikealfare
Copy link
Contributor Author

The CLA is failing because this PR contains all commits ever made to dbt-athena, which includes those prior to dbt Labs assuming ownership.

I ran all of the PR checks by adding the pull_request trigger to pull_request_checks.yml. The results passed. I then removed the trigger since we only want pull_request_target as a trigger.

Copy link

cla-bot bot commented Jan 10, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @maiarareinaldo, @sashakcc, @keshihoriuchi, @voroninman, @lukas-gust, @nicor88, @skirino, @brunofaustino, @svdimchenko, @artem-garmash, @hiro-o918, @SoumayaMauthoorMOJ

@mikealfare mikealfare marked this pull request as ready for review January 10, 2025 00:33
@mikealfare mikealfare requested a review from a team as a code owner January 10, 2025 00:33
Copy link

cla-bot bot commented Jan 10, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @maiarareinaldo, @sashakcc, @keshihoriuchi, @voroninman, @lukas-gust, @nicor88, @skirino, @brunofaustino, @svdimchenko, @artem-garmash, @hiro-o918, @SoumayaMauthoorMOJ

Copy link

cla-bot bot commented Jan 10, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @maiarareinaldo, @sashakcc, @keshihoriuchi, @voroninman, @lukas-gust, @nicor88, @skirino, @brunofaustino, @svdimchenko, @artem-garmash, @hiro-o918, @SoumayaMauthoorMOJ

Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments, probably minor. Nice to see unit tests are passing. I'd love to see a functional test run pass too. Not sure if that's possible at this stage. It would make sense to also have that follow on after merging and hotfixing as needed I suppose...

@mikealfare
Copy link
Contributor Author

Two comments, probably minor. Nice to see unit tests are passing. I'd love to see a functional test run pass too. Not sure if that's possible at this stage. It would make sense to also have that follow on after merging and hotfixing as needed I suppose...

It got pushed up off the screen. See my post above.

Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets go!

@mikealfare mikealfare merged commit b8c7938 into main Jan 12, 2025
31 of 32 checks passed
@mikealfare mikealfare deleted the monorepo/migrate-dbt-athena branch January 12, 2025 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.