-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADAP-1125: Migrate dbt-athena into dbt-adapters #399
Conversation
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jérémy Guiselin <[email protected]> Co-authored-by: Serhii Dimchenko <[email protected]> Co-authored-by: nicor88 <[email protected]>
Co-authored-by: Oleksandr Kot <[email protected]>
…tion (#385) Co-authored-by: Serhii Dimchenko <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…388) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: nicor88 <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: nicor88 <[email protected]>
…n `setuptools` (#399) Co-authored-by: nicor88 <[email protected]>
Co-authored-by: nicor88 <[email protected]>
Co-authored-by: Serhii Dimchenko <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…407) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Co-authored-by: Julien Kervizic <[email protected]> Co-authored-by: Serhii Dimchenko <[email protected]>
Co-authored-by: Serhii Dimchenko <[email protected]>
Co-authored-by: Serhii Dimchenko <[email protected]>
Co-authored-by: Serhii Dimchenko <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: nicor88 <[email protected]>
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @maiarareinaldo, @sashakcc, @keshihoriuchi, @voroninman, @lukas-gust, @nicor88, @skirino, @brunofaustino, @svdimchenko, @artem-garmash, @hiro-o918 |
The CLA is failing because this PR contains all commits ever made to I ran all of the PR checks by adding the pull_request trigger to |
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @maiarareinaldo, @sashakcc, @keshihoriuchi, @voroninman, @lukas-gust, @nicor88, @skirino, @brunofaustino, @svdimchenko, @artem-garmash, @hiro-o918, @SoumayaMauthoorMOJ |
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @maiarareinaldo, @sashakcc, @keshihoriuchi, @voroninman, @lukas-gust, @nicor88, @skirino, @brunofaustino, @svdimchenko, @artem-garmash, @hiro-o918, @SoumayaMauthoorMOJ |
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @maiarareinaldo, @sashakcc, @keshihoriuchi, @voroninman, @lukas-gust, @nicor88, @skirino, @brunofaustino, @svdimchenko, @artem-garmash, @hiro-o918, @SoumayaMauthoorMOJ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments, probably minor. Nice to see unit tests are passing. I'd love to see a functional test run pass too. Not sure if that's possible at this stage. It would make sense to also have that follow on after merging and hotfixing as needed I suppose...
It got pushed up off the screen. See my post above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets go!
Migrate
dbt-athena
into this repo using the following shell script and call:source ./scripts/migrate-adapter.sh dbt-athena main monorepo/migrate-dbt-athena
Update workflows to include
dbt-athena
anddbt-athena-community
.Make updates related with code quality checks due to slightly different config.
Merge this PR as a regular merge instead of a squash merge in order to retain git blame history.