Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required 'begin' config for testing microbatch models #314

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Sep 22, 2024

resolves #315
docs dbt-labs/docs.getdbt.com/#

Problem

dbt-core is adding a required config, named begin for microbatch models in dbt-labs/dbt-core#10756.

Solution

Add required begin config so tests continue to pass once the above dbt-core PR is in.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX

@cla-bot cla-bot bot added the cla:yes label Sep 22, 2024
Copy link

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@MichelleArk
Copy link
Contributor Author

MichelleArk commented Sep 23, 2024

Postgres testing:
✅ Using this branch + dbt-core@main (temp state until dbt-core PR is merged): https://github.com/dbt-labs/dbt-postgres/actions/runs/10999889426

✅ Using this branch + dbt-core@microbatch-begin-config (eventual state): https://github.com/dbt-labs/dbt-postgres/actions/runs/10999672904

@MichelleArk MichelleArk marked this pull request as ready for review September 23, 2024 18:06
@MichelleArk MichelleArk requested a review from a team as a code owner September 23, 2024 18:06
@colin-rogers-dbt colin-rogers-dbt merged commit f37b4cd into main Sep 23, 2024
15 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the add-microbatch-begin-config branch September 23, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dbt-test-adapters] Add required begin to microbatch model config to BaseMicrobatch test
3 participants