Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #310
Problem
When a model uses
get_columns_in_relation
on a table which includes columns of complex array types likeARRAY(VARCHAR(16777216))
, we raise an error because the pre-existing logic only expects there to be an int inside the parentheses. In this case we have nested types soVARCHAR(16777216)
cannot be converted to anint
and processing fails.Solution
Before we try to convert to an int, we run some new regex to check if this is a nested type, as in some alphabet chars followed by an open parentheses. If so, we do not try to extract a
char_size
,numeric_precision
, ornumeric_scale
and instead allow the code to return with those variables left asNone
.In the case of
VARCHAR(16777216)
, we would havedata_type = ARRAY, char_size = None, numeric_precision = None, numeric_scale = None
.Checklist