Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Introduce check-release-type CI workflow #214

Open
1 task done
MichelleArk opened this issue May 15, 2024 · 0 comments
Open
1 task done

[CI] Introduce check-release-type CI workflow #214

MichelleArk opened this issue May 15, 2024 · 0 comments
Labels
ci enhancement New feature or request

Comments

@MichelleArk
Copy link
Contributor

Housekeeping

  • I am a maintainer of dbt-adapters

Short description

Our changelog entries are great for end-user facing changelogs, but for programmatic consumers of dbt-adapters (e.g. dbt-core) -- they do not always accurately signal what kind of interface changes are occurring and possibly breaking. Ideally, this is communicated via the versioning of dbt-common, but the person releasing dbt-common needs to know what version to release!

To that end, we'd like to introduce a lightweight CI check that would be required on any PR to dbt-adapters. The CI check would require one of release_type: major, release_type: minor, release_type: patch labels to be applied to the PR prior to merging. That way, the person releasing dbt-common could pick the highest release type among a set of changes and infer the version to release of dbt-common.

Context

No response

Acceptance criteria

Introduce a required CI check on PRs that passes if one of release_type: major, release_type: minor, release_type: patch labels exists, and fails otherwise

Testing

Manual testing for CI check

Security

N/A

Docs

N/A

Consequences

N/A

@MichelleArk MichelleArk added enhancement New feature or request ci labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant