Add NonEmptyBlock class and utility functions
#178
Conversation
* This collection guarentees to have at least one element * Uses Scala cats [NonEmptyList](https://typelevel.org/cats/datatypes/nel.html) as inspiration Closes dbrattli#177
|
@dbrattli , interested to hear your thoughts. Would this be a collection type you'd be willing to merge? |
* Fix `non_empty_block._validate * Remove `non_empty_block.unfold` because it is not really needed with `block.unfold` available * Fix formatting
* Added unit tests * Removed `_head` and `_tail` as the same functionality is better implemented with `_block`
| # TODO: Not sure how to make this pass pyright | ||
| # Gives the following type of error: | ||
| # Type parameter "_TSource@NonEmptyBlock" is invariant, but "int" is not the same as | ||
| # "_TSourceSum@sum | Literal[0]" | ||
| #def test_non_empty_block_sum(): | ||
| # assert _test_value.sum() == 10 | ||
| # assert _test_value.pipe(non_empty_block.sum) == 10 | ||
| # | ||
| # | ||
| #def test_non_empty_block_sum_by(): | ||
| # assert _test_value.sum_by(lambda i: i * 10) == 100 | ||
| # assert _test_value.pipe(non_empty_block.sum_by(lambda i: i * 10)) == 100 |
There was a problem hiding this comment.
Not sure why this doesn't work. I looked at test_array.py#test_array_sum_works which is similar and passes the type checker, and I can't see what I'm doing wrong here 🤷
|
Looks very nice. Could we perhaps subclass Block to avoid so much code duplication? E.g by using the new |
Thanks for taking a look 👍 Some methods were not implemented in It might be a while before I get back to this PR again but I will take a look into that and see what's possible at some point. |
|
Hey @dbrattli . I just got around to looking at refactoring this to make For example, if I change def collect(self, mapping: Callable[[_TSource], Block[_TResult]]) -> Self[_TResult]:I get the following error from pyright: |
Closes #177