Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 1.9 / 2.0 support #10

Open
miah opened this issue Mar 18, 2013 · 4 comments
Open

Ruby 1.9 / 2.0 support #10

miah opened this issue Mar 18, 2013 · 4 comments

Comments

@miah
Copy link
Collaborator

miah commented Mar 18, 2013

"Ruby 1.8 and 2.0 have diverged so much that our britches have finally ripped. As of this writing (2013-03-18) I (dbrady) can get TourBus to build on 1.8.7 but not on ruby 1.9 or ruby 2.0. I think in the Very Near Future (which is hopefully much sooner than Real Soon Now) that Tourbus will go Ruby2-only and I’ll bump the version to 3.0 to keep people using 2.x from breaking hard."

@bbozo
Copy link

bbozo commented May 4, 2013

I use ruby 1.9.3 on https://github.com/bbozo/tourbus

@base10
Copy link

base10 commented Aug 8, 2013

I'm trying @bbozo's fork with 1.9.3-p392 and getting failures.

/Users/nathan/.rbenv/versions/1.9.3-p392/lib/ruby/1.9.1/rubygems/custom_require.rb:36:in `require': iconv will be deprecated in the future, use String#encode instead. /Users/nathan/.rbenv/versions/1.9.3-p392/lib/ruby/gems/1.9.1/gems/tourbus-2.0.2/bin/tourbus:8:in`': undefined method `symbolize_keys' for false:FalseClass (NoMethodError) from /Users/nathan/.rbenv/versions/1.9.3-p392/bin/tourbus:23:in`load' from /Users/nathan/.rbenv/versions/1.9.3-p392/bin/tourbus:23:in `'

@bbozo
Copy link

bbozo commented Aug 9, 2013

@base10, I was using 1.9.3-p286, but tested now with p392 too and no exception for me

last line of this code is generating the exception:

  # load config file, we'll use these as defaults
  config_file = ["./tourbus.yml", "./tours/tourbus.yml", "./config/tourbus.yml", "~/tourbus.yml"].map {|p| File.expand_path(p)}.find {|p| File.exists? p}
  config = config_file ? YAML::load_file(config_file).symbolize_keys : {}

a problem with the config file or yml library?

@base10
Copy link

base10 commented Aug 9, 2013

@bbozo Sure enough. Not having a tourbus.yml was the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants