Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with manifest on onFragment #291

Open
PonteIneptique opened this issue Feb 1, 2023 · 5 comments
Open

Bug with manifest on onFragment #291

PonteIneptique opened this issue Feb 1, 2023 · 5 comments

Comments

@PonteIneptique
Copy link

Hi there :)

I have been playing with the plugin in the last day, and something failed, probably because of a bad ALTO but I have stopped javascript for too long to be able to pinpoint more than a specific issue, which is IIIF-Commons/manifesto#121

Basically, there seems to be an issue with Fragment, which could be caused downstream of this plugin or downstream of manifesto. I wanted you to know this :)

@PonteIneptique
Copy link
Author

Hey :)
manifesto.js was updated (4.2.17), unfortunately I am unable to use it as a fix while using your repo in NPM. Could you upgrade the dep / build ? :)

@jbaiter
Copy link
Member

jbaiter commented Feb 24, 2023

I just published 0.3.8 on npm, can you check if it fixes your problem?

@PonteIneptique
Copy link
Author

Hey @jbaiter :) Yes it fixed the plugin issue but the code seems to be the same in the original mirador.js code (see the dirty fix I have to deploy: https://github.com/PonteIneptique/htr-light-viz-action/blob/main/dirty-fix.py )

This might be due to a parsing issue, or an ALTO having an incorrect line ?

@jbaiter
Copy link
Member

jbaiter commented Mar 2, 2023

Can you give me a sample ALTO that fails due to this bug?

@PonteIneptique
Copy link
Author

I am gonna try to set up an example by next week, I am in slow mode since a couple of days and I am trying to get back in the game ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants