Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Default for Health Check Endpoints for ECS Target Group #44

Open
swiknaba opened this issue Oct 29, 2021 · 1 comment
Open

Update Default for Health Check Endpoints for ECS Target Group #44

swiknaba opened this issue Oct 29, 2021 · 1 comment
Assignees
@swiknaba
Labels
enhancement New feature or request

Comments

@swiknaba
Copy link
Contributor

swiknaba commented Oct 29, 2021 •
edited
Loading

https://github.com/dbl-works/terraform/tree/main/ecs#health-checks

Kubernetes has updated their convention

The healthz endpoint is deprecated (since Kubernetes v1.16), and you should use the more specific livez and readyz endpoints instead

https://kubernetes.io/docs/reference/using-api/health-checks/

we likely want to default to /livez.

⚠️ we shouldn't update the default until we've upgraded all apps (e.g. add the /livez endpoint in addition to /healthz)
@swiknaba
Copy link
Contributor Author

the new stack module now uses /livez by default, see https://github.com/dbl-works/terraform/blob/v2022.06.23/stack/app/variables.tf#L114

@swiknaba swiknaba added the enhancement New feature or request label Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swiknaba swiknaba

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcqualie @swiknaba