Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor comments #1

Closed
christianholland opened this issue May 27, 2020 · 1 comment
Closed

Minor comments #1

christianholland opened this issue May 27, 2020 · 1 comment

Comments

@christianholland
Copy link

Hi David,

some minor comments I forgot to mention yesterday:

  • For the application it would be nice if you could provide some example data within the application (Could be similar to what I have done in the tab Enrichment analysis of this app: https://saezlab.shinyapps.io/reheat/). This would allow interested users and potential reviewers to explore your app in depth without the need to upload own data

  • You mixed up the x and y labels of the volcano plot in the README file

  • In my opinion It is a better practice to show the unadjusted p-value on the y-axis of the volcano plot. Why? Different p-values could map to the same adjusted p-value, so you loose some distinction/information between different genes. However, as a cutoff for regulation you should still use the corrected p-value

All the best,
Christian

@dbdimitrov
Copy link
Owner

dbdimitrov commented Jun 7, 2020

Hi Christian,

I appreciate the comments and suggestions.

The Volcano plot labels are now amended and I have changed the p-values in the VP according to your suggestion.

Also, example data does make a lot of sense for both potential users and reviewers. As such, example data has now been added for both Bulk and single-cell RNA-Seq.

I will mark this issue as closed, but please do not hesitate to open new ones in case you noticed anything else that could be improved.

Thanks a lot!

Kind regards,

Daniel

@dbdimitrov dbdimitrov pinned this issue Jun 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants