Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use of system prompt #13

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix: use of system prompt #13

merged 1 commit into from
Jan 15, 2025
+1 −4

Conversation

milancermak
Copy link
Collaborator

@milancermak milancermak commented Jan 15, 2025 •
edited by coderabbitai bot
Loading

The way to set a system prompt for Claude is via a designated system parameter, not as a message with an "assistant" role (that actually tells Claude that that message was his response). This PR fixes the bug.

Summary by CodeRabbit

  • Refactor
    • Simplified the message structure when sending requests to the Anthropic API.
    • Improved system prompt handling in the LLM client.

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 15, 2025 •
edited
Loading

Walkthrough

The pull request modifies the analyze method in the LLMClient class within the packages/core/src/core/llm-client.ts file. The change simplifies the message structure sent to the Anthropic API by directly assigning the system prompt and removing a separate message object with the "assistant" role. The system prompt is now conditionally set to an empty string if not provided, while maintaining the existing error handling and response parsing logic.

Changes

File Change Summary
packages/core/src/core/llm-client.ts Modified analyze method to simplify Anthropic API message structure by directly assigning system prompt

Poem

🐰 A Rabbit's API Refactor Delight 🤖
Messages trimmed, structure so neat
System prompt now direct and sweet
Anthropic's call, no extra fluff
Code simplified - that's rabbit stuff!

Hop hop hooray! 🎉

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b17c2af and 40f3626.

📒 Files selected for processing (1)
  • packages/core/src/core/llm-client.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/core/src/core/llm-client.ts
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@milancermak
Copy link
Collaborator Author

I actually think the system prompt should be set in the LLMClient at init time - my mental model is that you want it to be "active" during the whole session - but I'm still not 100% familiar with the codebase so maybe it does not make sense here? Thoughts?

@ponderingdemocritus
Copy link
Contributor

System prompt should be dynamic based on what you are calling - so it will change depending on the prompts

@milancermak milancermak merged commit ea13c2e into daydreamsai:main Jan 15, 2025
2 checks passed
@milancermak milancermak deleted the fix/system-prompt branch January 15, 2025 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ponderingdemocritus ponderingdemocritus Awaiting requested review from ponderingdemocritus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milancermak @ponderingdemocritus