Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rake spec failed: Sumomo does something useful #4

Open
szabgab opened this issue Dec 20, 2022 · 1 comment
Open

rake spec failed: Sumomo does something useful #4

szabgab opened this issue Dec 20, 2022 · 1 comment

Comments

@szabgab
Copy link

szabgab commented Dec 20, 2022

Before trying to setup GitHub Actions for this gem I tried it locally in an Ubuntu 22.10 based docker container after cloning the repo:

The ./bin/setup seemed to be successful, but showed me some warnings:

Using sumomo 0.8.22 from source at `.` and installing its executables
Bundle complete! 4 Gemfile dependencies, 364 gems now installed.
Use `bundle info [gemname]` to see where a bundled gem is installed.
Post-install message from trollop:
!    The 'trollop' gem has been deprecated and has been replaced by 'optimist'.
!    See: https://rubygems.org/gems/optimist
!    And: https://github.com/ManageIQ/optimist
Post-install message from rubyzip:
RubyZip 3.0 is coming!
**********************

The public API of some Rubyzip classes has been modernized to use named
parameters for optional arguments. Please check your usage of the
following classes:
  * `Zip::File`
  * `Zip::Entry`
  * `Zip::InputStream`
  * `Zip::OutputStream`

Please ensure that your Gemfiles and .gemspecs are suitably restrictive
to avoid an unexpected breakage when 3.0 is released (e.g. ~> 2.3.0).
See https://github.com/rubyzip/rubyzip for details. The Changelog also
lists other enhancements and bugfixes that have been implemented since
version 2.3.0.

# Do any other automated setup that you need to do here

rake spec however failed:

/usr/bin/ruby3.0 -I/var/lib/gems/3.0.0/gems/rspec-support-3.12.0/lib:/var/lib/gems/3.0.0/gems/rspec-core-3.12.0/lib /var/lib/gems/3.0.0/gems/rspec-core-3.12.0/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb

Sumomo
  has a version number
  does something useful (FAILED - 1)

Failures:

  1) Sumomo does something useful
     Failure/Error: expect(false).to eq(true)
     
       expected: true
            got: false
     
       (compared using ==)
     
       Diff:
       @@ -1 +1 @@
       -true
       +false
       
     # ./spec/sumomo_spec.rb:11:in `block (2 levels) in <top (required)>'

Finished in 0.0896 seconds (files took 1.23 seconds to load)
2 examples, 1 failure

Failed examples:

rspec ./spec/sumomo_spec.rb:10 # Sumomo does something useful

/usr/bin/ruby3.0 -I/var/lib/gems/3.0.0/gems/rspec-support-3.12.0/lib:/var/lib/gems/3.0.0/gems/rspec-core-3.12.0/lib /var/lib/gems/3.0.0/gems/rspec-core-3.12.0/exe/rspec --pattern spec/\*\*\{,/\*/\*\*\}/\*_spec.rb failed

Any steps I might have missed setting up the local development environment?

@davidsiaw
Copy link
Owner

No, the test is actually just the ordinary generated test when you create a Gemfile. Sorry. I need to write tests for this project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants