Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxJava 2.0 Planning? #63

Open
thomasnield opened this issue Sep 4, 2016 · 20 comments
Open

RxJava 2.0 Planning? #63

thomasnield opened this issue Sep 4, 2016 · 20 comments
Labels

Comments

@thomasnield
Copy link
Contributor

Hey @davidmoten,

This is probably going to be a somewhat large refactoring task. What are your plans with RxJava 2.0 being on the horizon? Will there be two versions of this codebase on two branches? With two separate 1.0.x and 2.0.x releases?

Tom

@davidmoten
Copy link
Owner

Hi Tom, haven't planned it yet. I'd support both rxjava 1.x and 2.x for a
good while but not sure if I'd branch this repo or fork to new repo
rxjava-jdbc2.

RxJava2 is a way off production ready and lots of api change still
happening so no rush I think.

Cheers
Dave

On Sun, 4 Sep 2016, 13:50 Thomas Nield [email protected] wrote:

Hey @davidmoten https://github.com/davidmoten,

This is probably going to be a somewhat large refactoring task. What are
your plans with RxJava 2.0 being on the horizon? Will there be two versions
of this codebase on two branches? With two separate 1.0.x and 2.0.x
releases?

Tom


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#63, or mute the thread
https://github.com/notifications/unsubscribe-auth/AATa63_Ui98HqLRMhT62aFfFoKsiwWyfks5qmkAOgaJpZM4J0c1f
.

@thomasnield
Copy link
Contributor Author

Well that's a relief, haha I was already planning my own libraries for the transition. I'm glad there is good reason to hold off then.

Sounds good. Ill adopt that fork approach for my stuff and recommend it to others, that's a good idea. You can close this issue or leave it open.

@akarnokd
Copy link

Switching between branches is somewhat inconvenient for me in RxJava. I'd prefer separate project so you can have both of them open in the same Eclipse workspace (not sure how IntelliJ would be affected).

I may be able to help you with porting this to 2.x but it really depends on the extra features you did or how deeply you depended on 1.x structure that has to be remade.

@thomasnield
Copy link
Contributor Author

@akarnokd I'm glad you're here, thanks for helping out. I can try to help you and @davidmoten but my low-level RxJava knowledge is limited, and I'm a bit overloaded with projects right now. I can assist with testing functionality on my end against SQLite, PostgreSQL, and MySQL.

@davidmoten
Copy link
Owner

thanks @akarnokd. Porting shouldn't be a problem for this one, thanks for the offer of help!

Speaking of switching branches between RxJava 1.x and 2.x in Eclipse what I did was cloned RxJava again to an RxJava2 folder and imported that to Eclipse as project rxjava2. That way I can have them both open.

@akarnokd
Copy link

Just fire up a new repo or branch (build ready) and I'll do the conversion.

@akarnokd
Copy link

Looks like rxjava-extras needs the conversion first, at least those parts used by this library.

@davidmoten
Copy link
Owner

Yep, I'll have a look at them both (or just the bits that rxjava-jdbc uses)
and plan it. rxjava-jdbc needs a rewrite I reckon, it predates useful
rxjava operators and predates my improved knowledge. Might leave that till
after a simple migration to 2.x though.

On Sun, 30 Oct 2016, 07:57 David Karnok [email protected] wrote:

Looks like rxjava-extras needs the conversion first, at least those parts
used by this library.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#63 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATa6ytjaxyRSIo4CufH6msGDj2Uoo3gks5q47M5gaJpZM4J0c1f
.

@krishna81m
Copy link

Hello, just checking if 2.x support is available in beta?

@thomasnield
Copy link
Contributor Author

@krishna81m I don't think it is. Last time I checked RxJava-Extras needed to be ported over to RxJava2 since it is a dependency. There likely needs to be some design decisions regarding Flowables vs Observables, and whether to support one or both (I'm leaning towards the latter since both can be included in the builder).

If you need to urgently use this with RxJava 2.0, I recommend looking at RxJava2Interop by David Karnok to convert the Observables into its RxJava 2.0 counterparts.

It's a bit unfortunate David and the other RxJava gurus are ridiculously busy. I'd take a stab at it but I'm busy writing the Learning RxJava book with Packt. If anybody can provide help I know many people (including myself) would be highly appreciative.

@davidmoten
Copy link
Owner

Hello, just checking if 2.x support is available in beta?
Thanks @thomasnield for answering. Use RxJava2Interop as suggested to use the existing library.

Work is under way on rxjava2-jdbc at https://github.com/davidmoten/rxjava2-jdbc as a complete rewrite. I'll get back to it shortly. New version is discussed at https://github.com/davidmoten/rxjava2-jdbc/wiki but is still in development (not passing all tests at the moment).

@ArekCzarnik
Copy link

any news on rxjava2-jdbc? it is still under development ?

@thomasnield
Copy link
Contributor Author

thomasnield commented May 17, 2017

@ArekCzarnik David Moten is pretty busy. I've created my own implementation in Kotlin to get by in the interim.

https://github.com/thomasnield/rxkotlin-jdbc/blob/master/src/main/kotlin/org/nield/rxkotlinjdbc/JdbcExtensions.kt

It's pretty lightweight and just leverages extension functions. It doesn't have the reactive parameter features though in RxJava-JDBC, as well as named parameters. And of course, it only works with Kotlin, not Java.

@davidmoten
Copy link
Owner

I imagine I'll juggle my priorities to favour rxjava2-jdbc given enough interest. It's on my radar (as is your book @thomasnield, thanks for answering).

@davidmoten
Copy link
Owner

Just got past a blocker in rxjava2-jdbc, development can accelerate now, if you watch the rxjava2-jdbc project you'll probably notice some action in the next week or so.

@thomasnield
Copy link
Contributor Author

@davidmoten awesome, thanks David!

@davidmoten
Copy link
Owner

davidmoten commented Jun 9, 2017

An update on rxjava2-jdbc:

  • I'm happy with its current state but I'll seek to increase test coverage over the next couple of weeks and will make minor api changes
  • I haven't added CallableStatement support yet
  • not planning on supporting autoMap to constructors (just to interfaces)
  • null handling needs some thinking still
  • I'll release an RC in a couple of weeks

You're welcome to have a play with it, I'll endeavour to keep master buildable till release.

@davidmoten
Copy link
Owner

Ah, needs more work, don't bother playing with it yet!

@davidmoten
Copy link
Owner

Ok, rxjava2-jdbc is up and running, tests pass now, 0.1-RC1 has been released to Maven Central so anyone interested have a play! https://github.com/davidmoten/rxjava2-jdbc

@thomasnield
Copy link
Contributor Author

@davidmoten awesome, thanks David! I'm going to share this right now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants