Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ollama_dart package still uses the deprecated "context" in GenerateCompletionRequest #631

Open
anujyadav140 opened this issue Jan 5, 2025 · 1 comment
Open

Ollama_dart package still uses the deprecated "context" in GenerateCompletionRequest #631

anujyadav140 opened this issue Jan 5, 2025 · 1 comment
Labels
p:langchain_ollama langchain_ollama package. p:ollama_dart ollama_dart package. t:bug Something isn't working

Comments

@anujyadav140
Copy link

Issue with current documentation:

Ollama_dart package still uses the deprecated "context" in GenerateCompletionRequest; I checked the latest Ollama documentation and tried to implement the context parameter in the GenerareCompletionRequest but was unable to do so because Ollama just does not support it right now, it has been deprecated.

Idea or request for content:

I think it should be phased out in general, even from the Ollama_dart codebase.
@anujyadav140 anujyadav140 added the t:documentation Improvements or additions to documentation label Jan 5, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in LangChain.dart Jan 5, 2025
@davidmigloz
Copy link
Owner

davidmigloz commented Jan 7, 2025 •
edited
Loading

thanks for the heads-up!
I'll align the latest changes to their API.

@davidmigloz davidmigloz added t:bug Something isn't working p:ollama_dart ollama_dart package. p:langchain_ollama langchain_ollama package. and removed t:documentation Improvements or additions to documentation labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p:langchain_ollama langchain_ollama package. p:ollama_dart ollama_dart package. t:bug Something isn't working
Projects
LangChain.dart
Status: 📋 Backlog
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davidmigloz @anujyadav140