Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to ignore rules directly from VSCode interface. #698

Open
Anthony-ROGER-ENSICAEN opened this issue May 20, 2024 · 5 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@Anthony-ROGER-ENSICAEN
Copy link

Is your feature request related to a problem? Please describe.
Checking french text, I encounter hundreds of errors instances, such as "a special space is required before ?" (Le point d'interrogation est précédé d'une espace fine insécable.). This make impossible to visually track real errors.

Describe the solution you'd like
It would be very nice if we could either (or both) get direct substitution, or at least ignore the rule directly from VSCode interface.

Thanks for the tool.

@Anthony-ROGER-ENSICAEN Anthony-ROGER-ENSICAEN added the enhancement New feature or request label May 20, 2024
@davidlday davidlday self-assigned this Sep 6, 2024
@davidlday
Copy link
Owner

Thanks for the feature suggestion!

I may need a little more information for this one, but will let you know.

@davidlday
Copy link
Owner

Can you elaborate on "get direct substitution"? I understand the part about ignoring the rule directly from VSCode (I can add that as a quick fix item), but not sure what you mean by the other. Thank you!

@davidlday
Copy link
Owner

@Anthony-ROGER-ENSICAEN - I think I know what you mean by "get direct substitution". Do you mean, make the same correction everywhere it appears in the current document?

@Anthony-ROGER-ENSICAEN
Copy link
Author

Hey David, thanks.

I can come up with some solutions.

The simplest one is to ignore this rule, so thanks for that.

We could consider automatically replacing the space with an "espace fine insécable" as we type, without requiring any action from the user. I got this idea from the WYSIWYG editor, which I'd like to get rid of. I use Asciidoc, and for many reasons, I would like to encourage students and colleagues to use it as well. However, the major difficulty is ensuring fine grammar corrections. Without this feature, it's hard to promote its adoption. So, many thanks for your efforts.

I'm not sure how difficult this would be to implement in a VSCode plugin, so as a fallback, we could have a manual action (using CTRL+SHIFT+P in VSCode) to make the relevant replacement. Alternatively, we could do this automatically when saving.

@davidlday
Copy link
Owner

davidlday commented Sep 16, 2024

@Anthony-ROGER-ENSICAEN - I have a feature embedded that does "Smart Formatting" on save. Currently it does a few simple things - smart quotes, ellipses, and dashes. I've been considering splitting it out into its own extension and providing more customization. Would that be of interest to you? Similar to how other editors allow a customized list of smart substitutions.

I'm going to go ahead and release the feature for ignoring a rule from the UI directly as a quick action, so hopefully that helps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants