Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up FRBC-specific content #1

Open
davidakelley opened this issue Oct 19, 2019 · 2 comments
Open

Clean up FRBC-specific content #1

davidakelley opened this issue Oct 19, 2019 · 2 comments

Comments

@davidakelley
Copy link
Owner

I cleaned up the README to remove FRBC specific language.

I think there's 2 things left to handle:

  • The path to the Haver folder.
  • The default directory for chidatadir.

Ideally, they'd be empty and have some sort of prompt but I also don't want to change it since you guys are still going to use it.

Ideas?

@ssordopalacios
Copy link
Collaborator

On the topic of removing FRBC-specific language, I think our best bet is to wait until v2.0.0 and then release that, with everything squashed into "Initial commit", and then go from there. We can maintain a GitLab-specific version of cbd prior to that version, but any future issues go on GitHub.

@ssordopalacios
Copy link
Collaborator

But to answer your question: we nixed that default chidata directory, but if I would be fine with specifying it in a configuration file somewhere in the project that has the work-tree skipped.

When it comes to the Haver folder, I actually think Haver likes the R:/_appl/HAVER/DATA, but we could also just specify that, the Bloomberg jar file path, and the FRED API Key in the same configuration file.

In v2.0.0, I wrote helper functions like cbd.source.connectBloomberg() that handle all of the connection-setting and checking. So all these would have to do is read the configuration file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants