Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this project dead? #245

Open
johnthagen opened this issue Sep 21, 2020 · 18 comments
Open

Is this project dead? #245

johnthagen opened this issue Sep 21, 2020 · 18 comments

Comments

@johnthagen
Copy link

There have been no commits for 1.5 years: https://github.com/davglass/license-checker/commits/master

Perhaps the README should be updated that this project is abandoned, if it is?

@johnthagen
Copy link
Author

Related: #223 (comment)

@johnthagen
Copy link
Author

See https://github.com/RSeidelsohn/license-checker-rseidelsohn as a possible active fork.

@Eli-Black-Work
Copy link

Looks dead to me, as well.

@Eli-Black-Work
Copy link

Possible replacement: https://github.com/microsoft/license-checker-webpack-plugin

@zrosenbauer
Copy link

zrosenbauer commented Mar 17, 2021

@davglass is taking sabbatical from Open Source

Screen Shot 2021-03-16 at 9 24 22 PM

@Bosch-Eli-Black @johnthagen we just forked it and are going to extend / continue to support work on at @bluenovaio. We will need to take some time to review the issues that are open and try and get the reporter to open on our repository once we are ready.

We will need to review license and other documents to adhere with our standards.

Fork: https://github.com/bluenovaio/license-checker

@johnthagen
Copy link
Author

That's great. Please take a look at https://github.com/RSeidelsohn/license-checker-rseidelsohn as they fork added some nice fixes and improvements as well.

@Eli-Black-Work
Copy link

@zrosenbauer Cool! 🙂 I've starred your project.

@johnthagen
Copy link
Author

Since @RSeidelsohn's fork is still active, pinging him for awareness. Perhaps you two can collaborate. Would be great to have this project revived. ❤️

@zrosenbauer
Copy link

zrosenbauer commented Mar 22, 2021 via email

@RSeidelsohn
Copy link

Yes, this project should not die. I love my job as a FE dev, but it's a full time job and in my spare time I care for my wife and our two children, which is pretty time consuming. Also, I try to find time for my (other) hobby as well - home brewing. So I do not find too much time caring for this project. Yet it is great for giving a small contribution to the community and it helps honing my skills and it is fun as well. So that being said, I try to do my best, yet I happily accept pull requests. This project is really small and should be great for beginning contributors as well.
I try to take care of the current two requests, hopefully next week end.

Cheers and thanks for the pings!

@zrosenbauer
Copy link

@RSeidelsohn can you shoot me an email at [email protected], I'd love to chat briefly about this project with you if you have a chance. Cheers.

@brebory
Copy link

brebory commented Aug 16, 2021

@Bosch-Eli-Black @johnthagen we just forked it and are going to extend / continue to support work on at @bluenovaio. We will need to take some time to review the issues that are open and try and get the reporter to open on our repository once we are ready.

We will need to review license and other documents to adhere with our standards.

Fork: https://github.com/bluenovaio/license-checker

@zrosenbauer is the bluenovaio fork defunct or moved? The link doesn't appear to work for me.

As someone looking to use this tool, should I be using the rseidelsohn fork or the bluenovaio fork?

@johnthagen
Copy link
Author

As someone looking to use this tool, should I be using the rseidelsohn fork or the bluenovaio fork?

I've found @RSeidelsohn's fork to work great. He's fixed several issues with the base repo. I haven't had any issues with his fork.

@zrosenbauer
Copy link

zrosenbauer commented Aug 16, 2021 via email

TheDome added a commit to neohelden/actions-library that referenced this issue Apr 26, 2022
This replaces the npm package license-checker by an active fork named license-checker-rseidelsohn
For further details see davglass/license-checker#245 (comment)
TheDome added a commit to neohelden/actions-library that referenced this issue Apr 26, 2022
This replaces the npm package license-checker by an active fork named license-checker-rseidelsohn
For further details see davglass/license-checker#245 (comment)
Additionally @neohelden/eslint-config will be allowed
@codepunkt
Copy link
Contributor

@johnthagen @Bosch-Eli-Black @RSeidelsohn @brebory @zrosenbauer As the author of webpack-license-plugin and someone responsible for JavaScript ecosystem OSS license compliance in a larger company, I would love to hear more about your use cases. Why are you using license-checker? What problem does it help you solve?

@johnthagen
Copy link
Author

@codepunkt We use a fork of license-checker to generate a static license report of all NPM dependencies to include with the built frontend to comply with OSS licenses requirements. We host this so that we can provide a link in our app for end users to view the licenses. This also helps give credit to these upstream packages.

Here is an example of creating such a report:

@Eli-Black-Work
Copy link

Eli-Black-Work commented Sep 22, 2022

We have a similar use case as @johnthagen: We generate a static license report of all NPM dependencies and feed that to a an OSS license scanner tool (similar to Blackduck).

We're currently using https://github.com/microsoft/license-checker-webpack-plugin, but that's repo is no longer maintained, as the owner of the repo is no longer at Microsoft.

@codepunkt
Copy link
Contributor

codepunkt commented Sep 22, 2022

@codepunkt We use a fork of license-checker to generate a static license report of all NPM dependencies to include with the built frontend to comply with OSS licenses requirements. We host this so that we can provide a link in our app for end users to view the licenses. This also helps give credit to these upstream packages.

Here is an example of creating such a report:

@johnthagen That's what I was suspecting most people would do with license-checker. Are you using webpack or rollup to build/bundle the frontends?

We have a similar use case as @johnthagen: We generate a static license report of all NPM dependencies and feed that to a an OSS license scanner tool (similar to Blackduck).

We're currently using https://github.com/microsoft/license-checker-webpack-plugin, but that's repo is no longer maintained, as the owner of the repo is no longer at Microsoft.

@Bosch-Eli-Black Switching to license-checker is problematic. You will get a lot of false positives and false negatives with your webpack build. We're building a large b2b application consisting of multiple microfrontends, each of them being a react app built with webpack. Using license-checker with settings like those shown from @johnthagen gave us a list of roughly 400 packages for our bill of materials. However, the real build output only includes ~250 packages - 50 of which are not included in the list given by license-checker. As it turns out, the only viable way to do this is to hook directly into the build process, because only the build tool or bundler knows what optimizations it makes. Which parts of the code are stripped out in production builds? What can be tree-shaken? Which parts of dependencies of dependencies are included in the build output that are not listed as dependencies, but devDependencies or optionalDependencies etc. Feel free to also take a look at webpack-license-plugin for your purposes.

I'm not trying to dismiss the awesome work the author and maintainer has done here. This repository was the starting point for our license compliance tooling aswell. I'm just trying to be realistic here - it is not a good choice if license compliance is important to you or your company to use it to generate bills of material.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants