Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Wordpress Rss Feed Problem #155

Open
amerlin opened this issue Jun 5, 2018 · 2 comments
Open

Wordpress Rss Feed Problem #155

amerlin opened this issue Jun 5, 2018 · 2 comments
Labels
⚠ Bug Something isn't working as expected

Comments

@amerlin
Copy link
Contributor

amerlin commented Jun 5, 2018

Hi, you have a problem with feed from my blogs:

http://amerlin.keantex.com/feed/
http://www.dotnettortona.net/feed/

If can help you, they are two wordpress blog.

Thanks!

@daveaglick daveaglick added the ⚠ Bug Something isn't working as expected label Jun 8, 2018
@SeanKilleen
Copy link
Contributor

I think I know what the issue is here.

Symptoms

The symptoms as far as I can tell are:

  • These blogs do not appear in the list of overall blogs
  • These blogs do appear in the search for blogs
  • When going to the page for the specific blogs on the site, it does not appear to load any posts.

Cause

The issue appears to be in https://github.com/daveaglick/discoverdotnet/blob/master/config.wyam#L207:

Where((doc, ctx) => doc.ContainsKey("FeedItems") && doc.String("Language") == "English"),

The language specified for these sites is Italian, so I don't believe Discover .NET (currently) supports extracting the feed items. Because the blogs have no found posts, they don't show up in the overall list of blogs, though one can still search for them.

@daveaglick can you confirm this?

Possible Remedies

Once Dave confirms the cause, I think there are a few remedies we could apply from a Discover .NET perspective -- I'd like to see if Dave thinks any of these are viable:

  • Start indexing posts for non-English languages: I'm not sure what previously prevented this, but it might be warranted to see if this can be accomplished now.
  • Allow for zero-post blogs that are non-English to be shown in the list of blogs: If Discover .NET currently experiences hiccups when parsing that content, it may still be nice to allow the blogs to show up in the overall list of blogs if they are non-English blogs. This will allow them to be shown at least.

Thoughts?

@daveaglick
Copy link
Owner

Great catch @SeanKilleen and definitly unintended behavior. I think you nailed the root cause. You're correct that non-English blogs are currently excluded from downloading posts. The intent was to ensure that posts on the home page were consistently the same language (otherwise it would get confusing and noisy). The unintended consiquence is that by excluding those posts we end up thinking the blog is empty and don't include it anywhere.

I think the following would be the ideal solution:

  • Start indexing non-English posts - we want them to show up in the post list for that blog and for the blog to show up in the list of blogs (and not be considered empty)
  • Instead of just not downloading non-English posts, exclude them from the homepage and aggregate feeds some other way by filtering on the language property
  • Eventually it would be nice to provide alternate laugage aggregate feeds and the option to swap the homepage posts lists to another language (and maybe remember that option per-user)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
⚠ Bug Something isn't working as expected
Projects
None yet
Development

No branches or pull requests

3 participants