Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use parameters in sync.sh as per datapub project, e.g. nhs, gdx. #2

Open
3 tasks
mbeilin opened this issue Oct 29, 2020 · 4 comments
Open
3 tasks

Use parameters in sync.sh as per datapub project, e.g. nhs, gdx. #2

mbeilin opened this issue Oct 29, 2020 · 4 comments
Assignees

Comments

@mbeilin
Copy link

mbeilin commented Oct 29, 2020

We need sync.sh file to be parametrized as per datapub project, for example for NHS it should look like this, while we are fetching datapub-nhs or just nhs from config.

(for datapub-nhs - https://github.com/datopian/datapub-nhs)

git clone [email protected]:datopian/datapub-nhs.git
cd datapub-nhs
yarn
yarn build
cd -
rm -r ckanext/datapub/fanstatic/**/*
cp -r datapub-nhs/build/static/* ckanext/datapub/fanstatic/

Acceptance

  • sync.sh is parametrized with what

Tasks

  • Set up variable in config to point to specific datapub project
  • sync.sh uses datapub specific project name as config variable
@anuveyatsu
Copy link
Member

is this a blocker @mbeilin @mariorodeghiero ?

@mbeilin
Copy link
Author

mbeilin commented Oct 29, 2020

is this a blocker @mbeilin @mariorodeghiero ?

yes, for NHS.
Atm I just override this in sep branch, so we can use it in Staging env - https://github.com/datopian/ckanext-datapub/blob/datapub-nhs/sync.sh

@mariorodeghiero
Copy link
Contributor

not for me, I'm doing manually because I using locally for while.

@mariorodeghiero
Copy link
Contributor

@mbeilin @anuveyatsu Irakli did some changes in the sync.sh file to execute everything automatically, and also to be able to insert the chunks in upload_module.html. So please take a look at these changes #4 because I will be helpful for NHS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants