Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerize project to make it more accessible to newcomers #721

Closed
amycommits opened this issue Oct 4, 2021 · 4 comments
Closed

Dockerize project to make it more accessible to newcomers #721

amycommits opened this issue Oct 4, 2021 · 4 comments
Labels

Comments

@amycommits
Copy link

Create a docker and docker-compose file so that people don't necessarily have to have Hugo and Yarn on their personal machines. Everyone's development environment is a little bit different, and this will help with basic errors.

For example:
I'm on a mac and hugo server failed, but hugo server --watch=false worked.

@mal-tee
Copy link
Member

mal-tee commented Oct 4, 2021

I think that specific problem is documented in the README, but sure. I think its a idea worth giving a shot, but only for developing purposes.

Shouldn't be too hard to implement for sb. with Docker knowledge. But I am not sure if we/@baltpeter want to maintain Docker-config stuff as well. 🤔

@baltpeter baltpeter added the idea label Oct 4, 2021
@baltpeter
Copy link
Member

Thanks for the suggestion!

As @mal-tee said, this would only be for dev purposes (as the project really isn't meant to be deployed by anyone other than us). Personally, I don't really see the need for that. Between the instructions and tips in the README, I think it shouldn't be too hard to get up and running for dev. And with #701, this will get even easier.

But I am not sure if we/@baltpeter want to maintain Docker-config stuff as well.

We could consider it if someone steps up to maintain that in the future. I will not be doing that.

@joremysh
Copy link

joremysh commented Oct 5, 2021

maybe I could help add a dockerfile to the project

@zner0L
Copy link
Member

zner0L commented Oct 6, 2021

I actually don't like this at all. Hugo and yarn are easy to use and build consistently across platforms. Docker just adds unnecessary overhead and adding a Dockerfile suggests that using Docker is needed for development or deployment. We even already provide containerization information for the CI (and netlify kinda). IMO, there is no need for docker if everybody already has a perfectly working unix shell in their OS.

@zner0L zner0L closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

5 participants