Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dial code broken for the Dominican Republic (DOM) #87

Closed
darnel opened this issue Oct 3, 2024 · 2 comments
Closed

Dial code broken for the Dominican Republic (DOM) #87

darnel opened this issue Oct 3, 2024 · 2 comments

Comments

@darnel
Copy link

darnel commented Oct 3, 2024

Previously line 69 was

DOM,"1-809,1-829,1-849",DOM,dr,Yes,214,72,DR,DR,DO,DOM,DOM,DOM,la República Dominicana,True,29,République dominicaine,...

with three separate dial codes 1-809, 1-829, 1-849 which seems correct (https://en.wikipedia.org/wiki/Area_codes_809,_829,_and_849) but the following commit

a09b84a#diff-99daf7ea0ec7335d0e8937a27e4fd2f024d8241703b6c084db4a48a698ad9c0b

changes line 68 to
DOM,1-8091-8291-849,DOM,dr,Yes,214,72.0,DR,DR,DO,DOM,DOM,DOM,la República Dominicana,1,29.0,République dominicaine,...

with single mixed dial code. This extensive change (or not correctly detected by diff) may brings additional similar errors.

Thanks.

@gradedSystem
Copy link
Member

@darnel Noted will fix that tomorrow

@gradedSystem
Copy link
Member

Should be fixed with this PR: #89

anuveyatsu added a commit that referenced this issue Oct 9, 2024
[update][s] Fixing Dial code problem - refs #87.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants