Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check tables in each GTFS file and verify them #134

Closed
CBROWN-ONS opened this issue Sep 15, 2023 · 2 comments
Closed

Check tables in each GTFS file and verify them #134

CBROWN-ONS opened this issue Sep 15, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request GTFS wontfix This will not be worked on
Milestone

Comments

@CBROWN-ONS
Copy link
Collaborator

          I can think of 2 other conditions we would want to check for raise:
  1. Fewer files than expected
  2. Additional files than expected (perhaps a warning is more appropriate here if we can test it without having it show up in test reports)

As logic not implemented, this can be a feature request. Would you agree?

Originally posted by @r-leyshon in #112 (comment)

@CBROWN-ONS CBROWN-ONS added technical debt A better way is available. Fix later approach has been adopted. GTFS enhancement New feature or request and removed technical debt A better way is available. Fix later approach has been adopted. labels Sep 15, 2023
@CBROWN-ONS CBROWN-ONS self-assigned this Sep 18, 2023
@CBROWN-ONS
Copy link
Collaborator Author

Discovery

It appears that gtfs-kit will only read in tables that are included the the following dictionary.
image
It will however not raise any errors or notifications, informing the user that it has not read this table, or that it even exists.

On the other hand, gtfs-kit will notify the user if one of the required tables are missing, This will appear in the table returned through feed.validation.

Recommendation

In this case, I recommend that we wait for the cleaners/validation modules to be merged with dev and then alert the user in the validation table of the invalid table that isn't being read as part of the GTFS feed.

@r-leyshon
Copy link
Contributor

Migrated to datasciencecampus/assess_gtfs#7

@r-leyshon r-leyshon closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request GTFS wontfix This will not be worked on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants