Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline method call with separate line for each param cop #71

Open
AleksSenkou opened this issue Jul 26, 2019 · 4 comments
Open

Multiline method call with separate line for each param cop #71

AleksSenkou opened this issue Jul 26, 2019 · 4 comments
Labels
feature request New feature or request postponed Not valuable for now

Comments

@AleksSenkou
Copy link

Is your feature request related to a problem? Please describe.
Multiline method call is waiting for a custom cop to be written. Details here - #39
Finished with this style (separate line for each param) - #39 (comment)

Additional context.
Should be discussed in details. Do we want it to be restricted?

@AleksSenkou AleksSenkou added the feature request New feature or request label Jul 26, 2019
@AleksSenkou AleksSenkou changed the title Title goes here Multiline method call with separate line for each param cop Jul 26, 2019
@roman-dubrovsky
Copy link
Contributor

roman-dubrovsky commented Jul 26, 2019

Additional context.

Can have conflicts with other metrics (like class or method size). Need to discuss it

@roman-dubrovsky
Copy link
Contributor

@AleksSenkou I'm not going to work on this story in nearest future. Would you like to discuss and resolve it? Or can we set postponed label and return to this issue later?

@AleksSenkou AleksSenkou added the postponed Not valuable for now label Jul 26, 2019
@AleksSenkou
Copy link
Author

Set postponed

@nikitasakau
Copy link
Member

So maybe we can continue discussion? I personally like more version when each literal on separate line, but why cops for alignments don't support using ONLY this style? (I mean that you can use this style for all options of ParameterAlignment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request postponed Not valuable for now
Projects
None yet
Development

No branches or pull requests

3 participants