Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install gem with mutant #64

Open
roman-dubrovsky opened this issue Jul 25, 2019 · 13 comments
Open

Can't install gem with mutant #64

roman-dubrovsky opened this issue Jul 25, 2019 · 13 comments
Labels
bug Something isn't working postponed Not valuable for now
Milestone

Comments

@roman-dubrovsky
Copy link
Contributor

roman-dubrovsky commented Jul 25, 2019

Has a dependecies conflict with mutant-rspec library

Fetching gem metadata from http://rubygems.org/.......
Fetching gem metadata from http://rubygems.org/.
Resolving dependencies........
Bundler could not find compatible versions for gem "parser":
  In snapshot (Gemfile.lock):
    parser (= 2.5.3.0)

  In Gemfile:
    mutant-rspec was resolved to 0.8.24, which depends on
      mutant (~> 0.8.24) was resolved to 0.8.24, which depends on
        parser (~> 2.5.1)

    datarockets-style (~> 0.2.0) was resolved to 0.2.0, which depends on
      rubocop (~> 0.73.0) was resolved to 0.73.0, which depends on
        parser (>= 2.6)

Running `bundle update` will rebuild your snapshot from scratch, using only
the gems in your Gemfile, which may resolve the conflict.

It can also be rubocop or mutant issue.

Mutant rspec: https://github.com/mbj/mutant/blob/master/docs/mutant-rspec.md

@roman-dubrovsky roman-dubrovsky added bug Something isn't working help wanted Extra attention is needed labels Jul 25, 2019
@TheBlackArroVV
Copy link
Contributor

TheBlackArroVV commented Jul 25, 2019

Looks like mutant want like versions of gem parser between 2.5.1 and 2.6.0 without including last one. And rubocop from 2.6.0, so i think the right way for fixing it is to open issue in mutant repository

Sincerely, yours cap

@roman-dubrovsky roman-dubrovsky added the postponed Not valuable for now label Jul 26, 2019
@roman-dubrovsky roman-dubrovsky added this to the 0.8.0 milestone Jan 27, 2020
@nikitasakau
Copy link
Member

Update about this problem:

Now we have a bit different versions but problem looks the same: rubocop upgrades parser, mutant can not get in time 🤷‍♂️.

Even a bit more difficult: mutant depends on unparser, and unparser can not get in time with parser upgrading. BUT unparser is a gem of mutant developer.

I've created issue - https://github.com/mbj/mutant/issues/992 in mutant rep and maintainer has already asked and self-assigned on it. So looks like he is going to fix it.

But what I noticed. Problems with parser is a pretty often meets. And looks like they need some time to upgrade it. I've seen when issue with almost the same problem created on September and fixed on January. Also he is linked my issue to https://github.com/mbj/unparser/issues/129. It was created on May and nothing finished.

Do we really need this gem? Even if we can install it, looks like we will get problems with parser in the future because they lock version. And we will not be able to upgrade rubocop for example. Or I'm wrong?

@roman-dubrovsky
Copy link
Contributor Author

Do we really need this gem?

@nikitasakov did you mean rubocop or mutant?

@nikitasakau
Copy link
Member

nikitasakau commented Jan 29, 2020

@roman-dubrovsky I mean mutant. Now rubocop does not allow to install mutant because of parser, but if we install it, mutant will not allow us update rubocop in the future because of parser again. Or I'm wrong?

@roman-dubrovsky
Copy link
Contributor Author

hm, looks like this issue is still relevant.

and yes, I want that we'll try to use mutant (especially until all of us don't know how to write good tests). This library adds good test coverage and allows avoiding a lot of code smells

@roman-dubrovsky roman-dubrovsky removed the help wanted Extra attention is needed label Feb 14, 2020
@roman-dubrovsky roman-dubrovsky removed this from the 0.8.0 milestone Feb 14, 2020
@nikitasakau
Copy link
Member

My issue resolved and now it is possible to install mutant-rspec. Can we close this issue or we will able to close it after mutant installation only? @roman-dubrovsky

@roman-dubrovsky
Copy link
Contributor Author

@nikitasakov 👍 can you check it locally and close the issue

@roman-dubrovsky roman-dubrovsky added this to the 0.9.0 milestone Mar 5, 2020
@nikitasakau
Copy link
Member

Checked, installed without any problems with current rubocop (0.80)

@mbj
Copy link

mbj commented Nov 23, 2020

@nikitasakov, @roman-dubrovsky I just found this issue.

Just as a heads up: Mutant is now much better maintained (and still free to use for OSS projects). The 0.10.x series is closely tracking the reminder of the ecosystem. Plus unparser got major updates that will make it easier to closely track parser.

I recommend to update to mutant-0.10.x.

@roman-dubrovsky
Copy link
Contributor Author

@mbj nice, thank you so much. I'll check it later.

@mbj
Copy link

mbj commented Nov 23, 2020

@roman-dubrovsky Have you been using mutant on this repo, or another repo where mutant conflicted with this repo?

@roman-dubrovsky
Copy link
Contributor Author

@mbj only in other repo for now

@mbj
Copy link

mbj commented Nov 25, 2020

@roman-dubrovsky is that other repo public?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working postponed Not valuable for now
Projects
None yet
Development

No branches or pull requests

4 participants