Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant lines in lazypredict.ipynb giving error #1

Open
Deepankar-98 opened this issue Sep 9, 2021 · 0 comments
Open

Redundant lines in lazypredict.ipynb giving error #1

Deepankar-98 opened this issue Sep 9, 2021 · 0 comments

Comments

@Deepankar-98
Copy link

Hi @dataprofessor,

I implemented the code given in lazypredict.ipynb and found 2 redundant lines giving several errors.

Also, others have raised this issue so it's not something only on my end.
ISSUE Link: shankarpandala/lazypredict#344

In cell 3 of lazypredict.ipynb this redundant lines is giving error:

models_train,predictions_train = clf.fit(X_train, X_train, y_train, y_train)
models_test,predictions_test = clf.fit(X_train, X_test, y_train, y_test)

and the above 2 lines shd be replaced by:

models_train, predictions_train = clf.fit(X_train, X_test, y_train, y_test)

Similarly for cell 7 the below 2 lines:

models_train,predictions_train = reg.fit(X_train, X_train, y_train, y_train)
models_test,predictions_test = reg.fit(X_train, X_test, y_train, y_test)

shd be replaced by

models_train, predictions_train = reg.fit(X_train, X_test, y_train, y_test)

Can I raise a PR and solve the above mentioned issue.

Thanks,
Deepankar

@Deepankar-98 Deepankar-98 changed the title Redundant lines in **lazypredict.ipynb** code giving error Redundant lines in lazypredict.ipynb code giving error Sep 9, 2021
@Deepankar-98 Deepankar-98 changed the title Redundant lines in lazypredict.ipynb code giving error Redundant lines in lazypredict.ipynb giving error Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@Deepankar-98 and others