Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dm.align.template_align modify the global rdkit behaviour #117

Open
hadim opened this issue Jul 19, 2022 · 2 comments
Open

dm.align.template_align modify the global rdkit behaviour #117

hadim opened this issue Jul 19, 2022 · 2 comments
Labels
bug Something isn't working low-priority

Comments

@hadim
Copy link
Contributor

hadim commented Jul 19, 2022

See https://github.com/datamol-org/datamol/blob/013d93012abb7fb309a382d8b3eedaca4c2f4425/datamol/align.py#L107

We should not modify the global behaviour. The best is probably to put back the original value if it has been modified. This is not ideal in when doing multithreading.

@hadim hadim added bug Something isn't working low-priority labels Jul 19, 2022
@maclandrol
Copy link
Member

Good point, I remember looking at that and did not find any way to know the current state of PreferCoordGen from python in order to restore it.

@hadim
Copy link
Contributor Author

hadim commented Jul 19, 2022

Ok thanks (that was my first guess as well). A context manager for this would be nice. I'll try to investigate this more and eventually raise an issue upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working low-priority
Projects
None yet
Development

No branches or pull requests

2 participants